Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] core: improve ready code warning timeout #33478

Closed

Conversation

Xavier-Do
Copy link
Contributor

The ready code warning timeout of 2 seconds can be confusing since
it is triggered just after the 2 seconds. We can log this message
at the end in order to give the real timeout.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

The ready code warning timeout of 2 seconds can be confusing since
it is triggered just after the 2 seconds. We can log this message
at the end in order to give the real timeout.
@robodoo robodoo added seen 🙂 CI 🤖 Robodoo has seen passing statuses labels May 18, 2019
@C3POdoo C3POdoo added the RD research & development, internal work label May 18, 2019
@d-fence
Copy link
Contributor

d-fence commented May 19, 2019

@robodoo r+

@robodoo robodoo added r+ 👌 and removed r+ 👌 CI 🤖 Robodoo has seen passing statuses labels May 19, 2019
@robodoo
Copy link
Contributor

robodoo commented May 19, 2019

Staging failed: ci/runbot on e07de51d34d5557371c1d0781e2d3c7a1fd485fe (view more at http://runbot.odoo.com/runbot/build/522867)

pniederlag pushed a commit to pniederlag/odoo that referenced this pull request May 19, 2019
The ready code warning timeout of 2 seconds can be confusing since
it is triggered just after the 2 seconds. We can log this message
at the end in order to give the real timeout.

closes odoo#33478

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
@Xavier-Do
Copy link
Contributor Author

Xavier-Do commented May 19, 2019

Looks like the default cpu-limit of test all was a little to low for enterprise. Changed it from 3600 to 5000.
@robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 CI 🤖 Robodoo has seen passing statuses labels May 19, 2019
@robodoo
Copy link
Contributor

robodoo commented May 19, 2019

Staging failed: timed out (>120 minutes)

@d-fence
Copy link
Contributor

d-fence commented May 19, 2019

seems that the CLA status was not sent to the mergebot !

@d-fence
Copy link
Contributor

d-fence commented May 19, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 labels May 19, 2019
@Xavier-Do
Copy link
Contributor Author

Xavier-Do commented May 19, 2019

seems that the CLA status was not sent to the mergebot !

The staging branches have the config "Default no run". I added the cla check to this config. I hope it will be taken into the current build since step all is not finished.

@Xavier-Do
Copy link
Contributor Author

Unfortunately the community build was already finished. I'm trying a manual rebuild but if the mergebot timeout before the end we may need anoter retry.

@robodoo robodoo added error 🙅 and removed r+ 👌 CI 🤖 Robodoo has seen passing statuses labels May 19, 2019
@robodoo
Copy link
Contributor

robodoo commented May 19, 2019

Staging failed: timed out (>120 minutes)

@Xavier-Do
Copy link
Contributor Author

@robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses merging 👷 and removed error 🙅 labels May 19, 2019
@robodoo
Copy link
Contributor

robodoo commented May 19, 2019

Merged, thanks!

@robodoo robodoo closed this May 19, 2019
@Xavier-Do
Copy link
Contributor Author

Finally!

@Xavier-Do Xavier-Do deleted the master-display-real-ready-time-xdo branch June 17, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants