[FIX] mail: add message_count on form view only if not explicit in view #34143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeubelle
suggested changes
Jun 14, 2019
kebeclibre
force-pushed
the
12.0-messag-count-lpe
branch
from
97ab000
to
0b19c31
Compare
|
@mge-odoo |
Before this commit, it was not possible to have the field message_attachment_count explicitly defined in the form view. It crashed inelegantly if it were the case After this commit, it is possible to have that field in the form view OPW 1998503
kebeclibre
force-pushed
the
12.0-messag-count-lpe
branch
from
0b19c31
to
d104344
Compare
mgeubelle
approved these changes
Jun 14, 2019
|
robodoo r+ |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a brand new model, add a brand new model mail.thread as a o2m
(Studio can do this)
now, click on add a line on that o2m
Before this commit, there was a crash in the JS, because of 7f97c9f
In short, message_attachment_count was always injected in the view
Creating the crash in our case, because no valid info was injected
After this commit, we inject the field only if it not present explicitly in the view
The form view of the o2m opens without problems
OPW 1998503
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr