Various fixes, mainly related to list column widths + editable readonly feature #37113

aab-odoo · 2019-09-19T08:31:48Z

ClassNames 'oe_read_only' (resp. 'oe_edit_only') can be used in
x2many lists to hide columns in 'edit' (resp. 'readonly') modes.

However, before this rev., there were two issues:

Having such a className on a tag didn't work well as
the 'display: none' rule didn't apply on the body cell (it only
applied on the button). Same could be observed on
nodes.
Having more than one invisible column (with those classNames)
didn't work either, because the footer cells weren't hidden.
We didn't notice it with one invisible column, because the
footer contained one cell less than the header and the body.

Those two issues could be observed on the mrp.bom form view.

Task 2068261

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

aab-odoo · 2019-09-19T12:49:23Z

robodoo rebase-ff

robodoo · 2019-09-19T12:50:05Z

Merge method set to rebase and fast-forward

aab-odoo

The first two fixes deserve tests :-)

aab-odoo · 2019-09-23T06:48:48Z

addons/web/static/src/js/views/list/list_editable_renderer.js

+     * is overflowing.
+     *
+     * @param {number} totalWidth
+     * @param {number} allowedWidth


aab-odoo · 2019-09-23T06:49:27Z

addons/web/static/src/js/views/list/list_editable_renderer.js

-        const thElements = [...thead.getElementsByTagName('th')];
-        const thWidths = thElements.map((th) => th.offsetWidth);
+        const allowedWidth = table.parentNode.offsetWidth;
+        const totalWidth = thElements.reduce((total, th) => total + th.offsetWidth, 0);


i'd do this in _trimLargestColumns

aab-odoo · 2019-09-23T06:51:41Z

addons/web/static/src/js/views/list/list_editable_renderer.js

@@ -1264,6 +1259,43 @@ ListRenderer.include({
            return $(th).outerWidth();
        });
    },
+    /**
+     * Set a maximum width on the largest columns in the list in case the table
+     * is overflowing.


I'd explain the whole idea of the algorithm here

aab-odoo · 2019-09-23T06:53:57Z

addons/web/static/src/js/views/list/list_editable_renderer.js

+            this._trimLargestColumns(totalWidth, allowedWidth);
+        }
+
+        const thWidths = thElements.map(th => Number(th.style.maxWidth.split('px')[0]) || th.offsetWidth);


not a fan of the maxWidth.split stuff, maybe we should try to find another way (like storing the max widths we set in another structure)

Since the commit allowing all list views to be editable, there are some views in which we need to ensure that certain fields are always readonly. Affected modules: - account - crm - product - purchase - sale Task 1967602

Changed the information dipslayed by the confirmation modal in multi edition in list views. Before this commit, the modal simply showed a one-line message with the amount of valid records. Now, there are 3 elements: - If all of the fields cannot be changed, a first line warns the amount of valid records. - A second (or first if all fields can be updated) line ensuring that the user is aware of the occuring changes. - A table displaying the affected field and the updated value (readonly widget with the new value). Part of task 1967602

Setting 'overflow: hidden' on the (hidden) textarea used to compute the (visible) textarea height ensures that there is no vertical scrollbar, which would lead to a not so precise computation of the height. The bug could be observed in sale.order form view, in the order line x2many (description field), and had been introduced by ef46378.

*:board,hr_skills Hold on tight, this is a tricky one. Allows *any* readonly list view (only plain lists, not x2manies) to become partially editable when checking records. This means that once checked, a record line acts just like it was in an editable list. You can click on it, edit any of its values as long as they're not constrained by readonly modifiers, and save them on the fly. Clicking on an unchecked record will have the same effect as before: it will open the record, regardless of the other selected records. You can also check multiple records and edit them all at once by changing the value of one selected record (just like standard multi edition). Keyboard navigation is also allowed between selected records (TAB and SHIFT+TAB to navigate and ENTER to save). /!\ If a list is only made of records having all of their fields locked by readonly modifiers, checking a record and clicking on it will do absolutely nothing. This is to keep consistency with the rest of the specs. Task 1967602

Go to Accounting > Accounting > General ledger. The view is grouped by account. There is a layout issue as the first column (date) is positionned after the group names, leaving a large blank space. This is because the date field is considered as an aggregated field (for sorting purpose, in python), but the JS can't (and we don't want to) display it. This rev. ensures that such field types are completely ignored by the JS, s.t. they do not impact the layout.

VincentSchippefilt · 2019-09-25T08:25:49Z

robodoo r+

robodoo · 2019-09-25T08:51:12Z

Linked pull request(s) odoo/enterprise#5745 not ready. Linked PRs are not staged until all of them are ready.

Go to Accounting > Accounting > General ledger. The view is grouped by account. There is a layout issue as the first column (date) is positionned after the group names, leaving a large blank space. This is because the date field is considered as an aggregated field (for sorting purpose, in python), but the JS can't (and we don't want to) display it. This rev. ensures that such field types are completely ignored by the JS, s.t. they do not impact the layout. closes #37113 Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>

xmo-odoo · 2019-09-25T12:49:54Z

@robodoo p=1

robodoo · 2019-09-25T12:56:13Z

Merged at 1787ff0, thanks!

robodoo · 2019-09-25T12:58:22Z

Unable to stage PR ({"message":"Merge conflict","documentation_url":"https://developer.github.com/v3/repos/merging/#perform-a-merge"})

Arcasias · 2019-10-09T12:31:21Z

@jpp-odoo commit for textarea line return: 67cccb5

jpp-odoo · 2019-10-09T12:34:59Z

@Arcasias Thanks!

robodoo added the seen 🙂 label Sep 19, 2019

C3POdoo added the RD research & development, internal work label Sep 19, 2019

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Sep 19, 2019

aab-odoo changed the title ~~[FIX] web: correctly handle 'oe_read|edit_only' in lists~~ Various fixes, mainly related to list column widths Sep 19, 2019

aab-odoo force-pushed the saas-12.5-list-fixes-aab branch 2 times, most recently from 8305017 to 0916f87 Compare September 19, 2019 13:03

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Sep 19, 2019

Arcasias force-pushed the saas-12.5-list-fixes-aab branch from 8790b6a to fb9327c Compare September 20, 2019 14:30

robodoo added the CI 🤖 Robodoo has seen passing statuses label Sep 20, 2019

aab-odoo commented Sep 23, 2019

View reviewed changes

aab-odoo force-pushed the saas-12.5-list-fixes-aab branch from fb9327c to 86074e8 Compare September 23, 2019 11:16

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Sep 23, 2019

aab-odoo force-pushed the saas-12.5-list-fixes-aab branch from 86074e8 to 6158f3e Compare September 23, 2019 13:13

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Sep 23, 2019

aab-odoo force-pushed the saas-12.5-list-fixes-aab branch from 6158f3e to 3316297 Compare September 24, 2019 07:07

robodoo removed the CI 🤖 Robodoo has seen passing statuses label Sep 24, 2019

aab-odoo force-pushed the saas-12.5-list-fixes-aab branch 2 times, most recently from 1269180 to c3cc028 Compare September 24, 2019 08:26

aab-odoo changed the title ~~Various fixes, mainly related to list column widths~~ Various fixes, mainly related to list column widths + editable readonly feature Sep 24, 2019

aab-odoo force-pushed the saas-12.5-list-fixes-aab branch 3 times, most recently from c75b767 to 8b93004 Compare September 24, 2019 13:01

aab-odoo force-pushed the saas-12.5-list-fixes-aab branch from 669ca94 to 1dc58c6 Compare September 25, 2019 07:19

Arcasias and others added 5 commits September 25, 2019 09:20

[IMP] *: editable readonly list views: adapt views

fef36e4

Since the commit allowing all list views to be editable, there are some views in which we need to ensure that certain fields are always readonly. Affected modules: - account - crm - product - purchase - sale Task 1967602

aab-odoo force-pushed the saas-12.5-list-fixes-aab branch from 1dc58c6 to 2bdc283 Compare September 25, 2019 07:21

robodoo added the CI 🤖 Robodoo has seen passing statuses label Sep 25, 2019

robodoo added the r+ 👌 label Sep 25, 2019

robodoo added the merging 👷 label Sep 25, 2019

robodoo added merged 🎉 and removed merging 👷 labels Sep 25, 2019

robodoo closed this Sep 25, 2019

robodoo added error 🙅 and removed CI 🤖 Robodoo has seen passing statuses merged 🎉 labels Sep 25, 2019

robodoo added CI 🤖 Robodoo has seen passing statuses merged 🎉 and removed error 🙅 labels Sep 25, 2019

fw-bot deleted the saas-12.5-list-fixes-aab branch October 18, 2019 10:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various fixes, mainly related to list column widths + editable readonly feature #37113

Various fixes, mainly related to list column widths + editable readonly feature #37113

aab-odoo commented Sep 19, 2019

aab-odoo commented Sep 19, 2019

robodoo commented Sep 19, 2019

aab-odoo left a comment

aab-odoo Sep 23, 2019

aab-odoo Sep 23, 2019

aab-odoo Sep 23, 2019

aab-odoo Sep 23, 2019

VincentSchippefilt commented Sep 25, 2019

robodoo commented Sep 25, 2019

xmo-odoo commented Sep 25, 2019

robodoo commented Sep 25, 2019

robodoo commented Sep 25, 2019

Arcasias commented Oct 9, 2019 •

edited

jpp-odoo commented Oct 9, 2019

Various fixes, mainly related to list column widths + editable readonly feature #37113

Various fixes, mainly related to list column widths + editable readonly feature #37113

Conversation

aab-odoo commented Sep 19, 2019

aab-odoo commented Sep 19, 2019

robodoo commented Sep 19, 2019

aab-odoo left a comment

Choose a reason for hiding this comment

aab-odoo Sep 23, 2019

Choose a reason for hiding this comment

aab-odoo Sep 23, 2019

Choose a reason for hiding this comment

aab-odoo Sep 23, 2019

Choose a reason for hiding this comment

aab-odoo Sep 23, 2019

Choose a reason for hiding this comment

VincentSchippefilt commented Sep 25, 2019

robodoo commented Sep 25, 2019

xmo-odoo commented Sep 25, 2019

robodoo commented Sep 25, 2019

robodoo commented Sep 25, 2019

Arcasias commented Oct 9, 2019 • edited

jpp-odoo commented Oct 9, 2019

Arcasias commented Oct 9, 2019 •

edited