Master pivot owl pro #39491
Closed
Master pivot owl pro #39491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-odoo
force-pushed
the
master-pivot-owl-pro
branch
3 times, most recently
from
6bf4f16
to
12f2962
Compare
VincentSchippefilt
force-pushed
the
master-pivot-owl-pro
branch
from
12f2962
to
f1820bc
Compare
pro-odoo
force-pushed
the
master-pivot-owl-pro
branch
from
f1820bc
to
3d08206
Compare
robodoo
added
CI 🤖
pro-odoo
force-pushed
the
master-pivot-owl-pro
branch
from
3d08206
to
6c10d51
Compare
pro-odoo
force-pushed
the
master-pivot-owl-pro
branch
2 times, most recently
from
c053fe4
to
7950f28
Compare
pro-odoo
force-pushed
the
master-pivot-owl-pro
branch
from
7950f28
to
a7dfc2f
Compare
robodoo
added
CI 🤖
pro-odoo
force-pushed
the
master-pivot-owl-pro
branch
from
a7dfc2f
to
ce80fa5
Compare
VincentSchippefilt
force-pushed
the
master-pivot-owl-pro
branch
4 times, most recently
from
e4fa9b5
to
ce80fa5
Compare
pro-odoo
force-pushed
the
master-pivot-owl-pro
branch
from
ce80fa5
to
ace5167
Compare
pro-odoo
force-pushed
the
master-pivot-owl-pro
branch
from
934f428
to
d12534c
Compare
With this commit, we properly introduce the Owl library into our beloved codebase. More information on the Owl library can be found in the project repository: https://github.com/odoo/owl/ Co-authored-by: Aaron Bohy <aab@odoo.com> Co-authored-by: Julien Mougenot <jum@odoo.com> Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
In this commit: - transformed test_utils helpers to always trigger native events - introduced new test_utils_create helper: prepareTarget - updated qunit asserts to support Owl Components - updated all misused helpers that would crash with the updated test_utils Co-authored-by: Julien Mougenot <jum@odoo.com> Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com> Co-authored-by: Pierre Rousseau <pro@odoo.com>
Changed the triggering of some events to dispatch native events instead of jQuery ones and extended the api of the keydown helper to support text keys.
Add a base class for a complete OWL renderer Add a compatibility layer for a Odoo controller that uses a OWL renderer. Co-authored-by: Pierre Rousseau <pro@odoo.com>
VincentSchippefilt
force-pushed
the
master-pivot-owl-pro
branch
from
d12534c
to
d41e738
Compare
robodoo
added
CI 🤖
|
robodoo rebase-merge r+ |
|
robodoo r- |
|
Merge method set to rebase and merge, using the PR as merge commit message |
Add custom hooks file to put the generic (low level) hooks used by Odoo
Duplicate the template of no content helper so it is available both in Odoo legacy QWeb and in OWL QWeb templates
Because the webclient and other higher level components such as the actionManager are not yet rewritten in OWL, we cannot make a complete migration of the controller and the model to a more OWL-ish code. We have rewritten the renderer completely in OWL, it uses more extensively a template and manages its own state and its sub-components. We did not rewrite the controller, however we have made it inherit from `web.ControllerAdapter` which is a thin compatibility layer used when a odoo controller uses a OWL renderer. In the tests, the only changes are that all the events triggered by the test and handled by OWL must be triggered on DOM nodes directly and not on JQuery elements. co-authored-by: VincentSchippefilt <vsc@odoo.com> co-authored-by: pro-odoo <pro@odoo.com>
VincentSchippefilt
force-pushed
the
master-pivot-owl-pro
branch
from
d41e738
to
eb2a1a2
Compare
|
robodoo rebase-ff |
|
Merge method set to rebase and fast-forward |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 9, 2019
Because the webclient and other higher level components such as the actionManager are not yet rewritten in OWL, we cannot make a complete migration of the controller and the model to a more OWL-ish code. We have rewritten the renderer completely in OWL, it uses more extensively a template and manages its own state and its sub-components. We did not rewrite the controller, however we have made it inherit from `web.ControllerAdapter` which is a thin compatibility layer used when a odoo controller uses a OWL renderer. In the tests, the only changes are that all the events triggered by the test and handled by OWL must be triggered on DOM nodes directly and not on JQuery elements. closes #39491 Related: odoo/enterprise#7135 Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com> Co-authored-by: VincentSchippefilt <vsc@odoo.com> Co-authored-by: pro-odoo <pro@odoo.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr