Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master pivot owl pro #39491

Closed
wants to merge 7 commits into from
Closed

Master pivot owl pro #39491

wants to merge 7 commits into from

Conversation

@aab-odoo
Copy link
Contributor

aab-odoo commented Oct 29, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Oct 29, 2019
@C3POdoo C3POdoo added the RD label Oct 29, 2019
@pro-odoo pro-odoo force-pushed the odoo-dev:master-pivot-owl-pro branch 3 times, most recently from 6bf4f16 to 12f2962 Oct 31, 2019
@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:master-pivot-owl-pro branch from 12f2962 to f1820bc Nov 5, 2019
@robodoo robodoo added the CI 🤖 label Nov 5, 2019
@pro-odoo pro-odoo force-pushed the odoo-dev:master-pivot-owl-pro branch from f1820bc to 3d08206 Nov 6, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 6, 2019
@pro-odoo pro-odoo force-pushed the odoo-dev:master-pivot-owl-pro branch from 3d08206 to 6c10d51 Nov 6, 2019
@robodoo robodoo removed the CI 🤖 label Nov 6, 2019
@pro-odoo pro-odoo force-pushed the odoo-dev:master-pivot-owl-pro branch 2 times, most recently from c053fe4 to 7950f28 Nov 6, 2019
@robodoo robodoo added the CI 🤖 label Nov 6, 2019
@KangOl KangOl force-pushed the odoo:master branch from 86c80d3 to ab6d0c3 Nov 6, 2019
@pro-odoo pro-odoo force-pushed the odoo-dev:master-pivot-owl-pro branch from 7950f28 to a7dfc2f Nov 7, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 7, 2019
@pro-odoo pro-odoo force-pushed the odoo-dev:master-pivot-owl-pro branch from a7dfc2f to ce80fa5 Nov 7, 2019
@robodoo robodoo removed the CI 🤖 label Nov 7, 2019
@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:master-pivot-owl-pro branch 4 times, most recently from e4fa9b5 to ce80fa5 Nov 12, 2019
@robodoo robodoo added the CI 🤖 label Nov 12, 2019
addons/web/static/src/js/env.js Outdated Show resolved Hide resolved
addons/web/static/src/js/env.js Show resolved Hide resolved
addons/web/static/src/js/env.js Outdated Show resolved Hide resolved
addons/web/static/src/js/env.js Outdated Show resolved Hide resolved
addons/web/static/src/js/odoo_qweb.js Outdated Show resolved Hide resolved
addons/web/static/src/js/views/pivot/pivot_model.js Outdated Show resolved Hide resolved
@pro-odoo pro-odoo force-pushed the odoo-dev:master-pivot-owl-pro branch from ce80fa5 to ace5167 Nov 12, 2019
@robodoo robodoo removed the CI 🤖 label Nov 12, 2019
@pro-odoo pro-odoo force-pushed the odoo-dev:master-pivot-owl-pro branch 2 times, most recently from 934f428 to d12534c Dec 6, 2019
@robodoo robodoo added the CI 🤖 label Dec 6, 2019
ged-odoo and others added 4 commits Aug 23, 2019
With this commit, we properly introduce the Owl library into our beloved
codebase. More information on the Owl library can be found in the project
repository: https://github.com/odoo/owl/

Co-authored-by: Aaron Bohy <aab@odoo.com>
Co-authored-by: Julien Mougenot <jum@odoo.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Add a base class for a complete OWL renderer
Add a compatibility layer for a Odoo controller that uses a OWL renderer.

Co-authored-by: Pierre Rousseau <pro@odoo.com>
Changed the triggering of some events to dispatch native events instead of
jQuery ones and extended the api of the keydown helper to support text keys.
In this commit:
- transformed test_utils helpers to always trigger native events
- introduced new test_utils_create helper: prepareTarget
- updated qunit asserts to support Owl Components
- updated all misused helpers that would crash with the updated test_utils

Co-authored-by: Julien Mougenot <jum@odoo.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Co-authored-by: Pierre Rousseau <pro@odoo.com>
@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:master-pivot-owl-pro branch from d12534c to d41e738 Dec 9, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 9, 2019
@VincentSchippefilt

This comment has been minimized.

Copy link
Contributor

VincentSchippefilt commented Dec 9, 2019

robodoo rebase-merge r+

@VincentSchippefilt

This comment has been minimized.

Copy link
Contributor

VincentSchippefilt commented Dec 9, 2019

robodoo r-

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Dec 9, 2019

Merge method set to rebase and merge, using the PR as merge commit message

pro-odoo and others added 3 commits Nov 5, 2019
Duplicate the template of no content helper so it is available both in
Odoo legacy QWeb and in OWL QWeb templates
Because the webclient and other higher level components such as the
actionManager are not yet rewritten in OWL, we cannot make a complete
migration of the controller and the model to a more OWL-ish code.

We have rewritten the renderer completely in OWL, it uses more
extensively a template and manages its own state and its sub-components.

We did not rewrite the controller, however we have made it inherit from
`web.ControllerAdapter` which is a thin compatibility layer used when a
odoo controller uses a OWL renderer.

In the tests, the only changes are that all the events triggered by the
test and handled by OWL must be triggered on DOM nodes directly and not
on JQuery elements.

co-authored-by: VincentSchippefilt <vsc@odoo.com>
co-authored-by: pro-odoo <pro@odoo.com>
Add custom hooks file to put the generic (low level) hooks used by Odoo
@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:master-pivot-owl-pro branch from d41e738 to eb2a1a2 Dec 9, 2019
@robodoo robodoo removed the CI 🤖 label Dec 9, 2019
@VincentSchippefilt

This comment has been minimized.

Copy link
Contributor

VincentSchippefilt commented Dec 9, 2019

robodoo rebase-ff

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Dec 9, 2019

Merge method set to rebase and fast-forward

@VincentSchippefilt

This comment has been minimized.

Copy link
Contributor

VincentSchippefilt commented Dec 9, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Dec 9, 2019
Because the webclient and other higher level components such as the
actionManager are not yet rewritten in OWL, we cannot make a complete
migration of the controller and the model to a more OWL-ish code.

We have rewritten the renderer completely in OWL, it uses more
extensively a template and manages its own state and its sub-components.

We did not rewrite the controller, however we have made it inherit from
`web.ControllerAdapter` which is a thin compatibility layer used when a
odoo controller uses a OWL renderer.

In the tests, the only changes are that all the events triggered by the
test and handled by OWL must be triggered on DOM nodes directly and not
on JQuery elements.

closes #39491

Related: odoo/enterprise#7135
Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
Co-authored-by: VincentSchippefilt <vsc@odoo.com>
Co-authored-by: pro-odoo <pro@odoo.com>
@robodoo robodoo closed this Dec 9, 2019
@robodoo robodoo deployed to merge Dec 9, 2019 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.