feat(purchase): add price difference valuation account to coa (TODO) #40158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Who to ping again? (It's time for OWNERS files!) |
blaggacao
force-pushed
the
master-add-purchase-property-account
branch
from
834539a
to
8baf3cd
Compare
Analog to srtock_account, the purchase driven company dependent field `property_account_creditor_price_difference_categ` should obtain a proper default value from the chart of account.
blaggacao
force-pushed
the
master-add-purchase-property-account
branch
from
8baf3cd
to
2fafd6a
Compare
You mean the git history? I don't think it is very healthy for a project to have single point of contact (and even less hardcoding it in the repository). For this accounting issue, that would probably be @qdp-odoo or @oco-odoo Thanks |
blaggacao
changed the title
|
@Deiber could you please have a look at the failing logs / force-push a fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Analog to
stock_account, the purchase driven company dependent fieldproperty_account_creditor_price_difference_categshould obtain aproper default value from the chart of account.
Motivation
Same as for
stock_account.Installing a CoA is an act of defaulting to CoA scoped accounting configuration. There is no reason, why this specific setting should be handled differently (no default). It seems the current implementation is inconsistent in that regard. This PR aligned the behaviour of this particular case with the behaviours of it's peers.
It reduces hard to fix implementation errors.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@xoe-labs