Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] web: scroll back to previous position after form buttons click. #46612

Closed
wants to merge 5 commits into from

Conversation

obayit
Copy link
Contributor

@obayit obayit commented Feb 28, 2020

This fixes issue #46060

Current behavior before PR:
Forms scroll return to the top after calling a button.

Desired behavior after PR is merged:
Forms scroll return to previous location after calling a button.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Call setLocalStateI() after _update is done, so that scrolling back to old location can work.
Added scroll location to setLocalState() and getLocalstate().
Also moved active notebook pages variable to an object inside state, instead of directly in state; to avoid having a notebook with the same name as 'scrollTop'.
@obayit
Copy link
Contributor Author

obayit commented Feb 28, 2020

I want to redo this to avoid conflicts with master

@obayit obayit reopened this Feb 28, 2020
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Feb 29, 2020
@obayit obayit changed the title Obayit patch 1 [IMP] web: scroll back to previous position after form buttons click. Mar 2, 2020
@obayit obayit closed this Sep 30, 2020
@robodoo robodoo added closed 💔 and removed CI 🤖 Robodoo has seen passing statuses labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants