[FW][FIX] hr_holidays: allocation multi-company #48753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpany Current Behaviour: As Admin: - Install timeoff and enable Multi company - Create new company and switch to that company - Go to timeoff > Managers > All > Allocations > Create a record An AccessError is raised from `_onchange_type` because it try to access `employee_ids[:1].id` and it may gives employee of another company. Expected Behaviour: After this commit, it will not raise the AccessError. if employee of that company is exist then and then set on leave allocation. so we have already compute field `employee_id`, it will gives employee of current company. Taskid: 2179571 Closes: odoo#45381 X-original-commit: 73b3d11
|
This PR targets 13.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
|
I'm sorry, @tivisse. This PR is already reviewed, reviewing it again is useless. |
immontilla
pushed a commit
to immontilla/odoo
that referenced
this pull request
Apr 26, 2020
…mpany Current Behaviour: As Admin: - Install timeoff and enable Multi company - Create new company and switch to that company - Go to timeoff > Managers > All > Allocations > Create a record An AccessError is raised from `_onchange_type` because it try to access `employee_ids[:1].id` and it may gives employee of another company. Expected Behaviour: After this commit, it will not raise the AccessError. if employee of that company is exist then and then set on leave allocation. so we have already compute field `employee_id`, it will gives employee of current company. closes odoo#48753 Taskid: 2179571 Closes: odoo#45381 X-original-commit: 73b3d11 Related: odoo/enterprise#9588 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Mitchell Admin:
An AccessError is raised from
_onchange_typebecausewe try to access
employee_ids[:1].idand it may gives employee of another company.we have already compute field
employee_id, it will gives employee of curren company.After this AccessError is solved.
task - 2179571
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #45381