Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] website_forum: force image size in css to handle gifs #48776

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 1, 2020

Issue

- Preferences > Change your avatar with a big .gif
- Install Forum
- Go on a question

The gif is not resized in the nav and in the post
answer box

Cause

In fact, all gifs are not really resized. They just
look fine because there is CSS to handle the case
where the server resize does not work.

Solution

Do as it is done everywhere else, add CSS rules

OPW-2223260

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #48390

Issue

	- Preferences > Change your avatar with a big .gif
	- Install Forum
	- Go on a question

	The gif is not resized in the nav and in the post
	answer box

Cause

	In fact, all gifs are not really resized. They just
	look fine because there is CSS to handle the case
	where the server resize does not work.

Solution

	Do as it is done everywhere else, add CSS rules

OPW-2223260

X-original-commit: 35137ce
@robodoo robodoo added forwardport This PR was created by @fw-bot seen 🙂 labels Apr 1, 2020
@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 1, 2020

This PR targets saas-13.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 1, 2020
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 1, 2020
@robodoo robodoo added the r+ 👌 label Apr 2, 2020
@robodoo robodoo added merging 👷 and removed CI 🤖 Robodoo has seen passing statuses merging 👷 labels Apr 2, 2020
@robodoo
Copy link
Contributor

robodoo commented Apr 2, 2020

Staging failed: ci/runbot on fd6efde99271129bca6e1460fa48e9b0c8eb4383 (view more at http://runbot.odoo.com/runbot/build/2002015)

@Xavier-Do
Copy link
Contributor

robodoo retry

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses r+ 👌 and removed error 🙅 labels Apr 2, 2020
robodoo pushed a commit that referenced this pull request Apr 2, 2020
Issue

	- Preferences > Change your avatar with a big .gif
	- Install Forum
	- Go on a question

	The gif is not resized in the nav and in the post
	answer box

Cause

	In fact, all gifs are not really resized. They just
	look fine because there is CSS to handle the case
	where the server resize does not work.

Solution

	Do as it is done everywhere else, add CSS rules

OPW-2223260

closes #48776

X-original-commit: 35137ce
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
@robodoo robodoo closed this Apr 2, 2020
@robodoo robodoo temporarily deployed to merge April 2, 2020 13:27 Inactive
@fw-bot fw-bot deleted the saas-13.3-13.0-opw-2223260-fix-image-size-forum-jvm-E06N-fw branch April 16, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants