[FIX] account: impossible to re-post if post_at_bank_rec #52165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OPW 2267661 |
|
cc @simongoffin |
|
ping @qdp-odoo |
simongoffin
reviewed
Jun 4, 2020
| if self.mapped('line_ids.payment_id'): | ||
| if any(self.mapped('journal_id.post_at_bank_rec')): | ||
| raise UserError(_("A payment journal entry generated in a journal configured to post entries only when payments are reconciled with a bank statement cannot be manually posted. Those will be posted automatically after performing the bank reconciliation.")) | ||
| if self.filtered(lambda x: x.journal_id.post_at_bank_rec).mapped('line_ids.payment_id').filtered(lambda x: x.state in ('draft', 'posted', 'sent')): |
There was a problem hiding this comment.
@fmdl Why no writing .filtered(lambda x: x.state != 'reconciled') instead?
|
Hello @qdp-odoo Is it ok for you? |
robodoo
added
CI 🤖
robodoo
added
CI 🤖
simongoffin
reviewed
Jun 9, 2020
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 9, 2020
closes #52165 Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
This was referenced Jun 9, 2020
This was referenced Jun 11, 2020
|
This pull request has forward-port PRs awaiting action (not merged or closed): #52811 |
2 similar comments
|
This pull request has forward-port PRs awaiting action (not merged or closed): #52811 |
|
This pull request has forward-port PRs awaiting action (not merged or closed): #52811 |
AdriaGForgeFlow
pushed a commit
to ForgeFlow/odoo
that referenced
this pull request
Jan 28, 2021
closes odoo#52165 Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
--> Issue impossible
Current behavior before PR:
Impossbile to re-post
Desired behavior after PR is merged:
Allow to re-post.
@qdp-odoo
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr