Master time off accrual plan crm #52298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tivisse
requested changes
Jun 3, 2020
There was a problem hiding this comment.
First review.
Installing a linter is mandatory. Reading carefully our coding guidelines is strongly recommended.
A lot of cosmetic comments. But also some more technical. It would have been correct to define a o2m field instead of as many selection fields as possible to configure 4 periods.
Nothing about the way leaves are actually computed for the employees is already done. No unit tests too.
Still some polishing to make here + There's no test.
Thanks for your work anyway.
robodoo
added
CI 🤖
odoo-crm
force-pushed
the
master-time_off-accrual_plan-crm
branch
from
8a0f6e4
to
3a589cf
Compare
robodoo
added
CI 🤖
odoo-crm
force-pushed
the
master-time_off-accrual_plan-crm
branch
from
3a589cf
to
8311739
Compare
robodoo
added
CI 🤖
odoo-crm
force-pushed
the
master-time_off-accrual_plan-crm
branch
from
8311739
to
e0a09cf
Compare
robodoo
added
CI 🤖
odoo-crm
force-pushed
the
master-time_off-accrual_plan-crm
branch
from
e0a09cf
to
236d60e
Compare
robodoo
added
CI 🤖
odoo-crm
force-pushed
the
master-time_off-accrual_plan-crm
branch
from
236d60e
to
93bab2c
Compare
robodoo
added
CI 🤖
odoo-crm
force-pushed
the
master-time_off-accrual_plan-crm
branch
from
0fa522d
to
c9baf90
Compare
robodoo
added
CI 🤖
odoo-crm
force-pushed
the
master-time_off-accrual_plan-crm
branch
from
c9baf90
to
dc18138
Compare
robodoo
added
☐ ci/runbot
and removed
CI 🤖
odoo-crm
force-pushed
the
master-time_off-accrual_plan-crm
branch
from
c8124f2
to
ae77ccc
Compare
robodoo
added
☑ legal/cla
CI 🤖
robodoo
added
☐ ci/runbot
CI 🤖
|
Hello @tivisse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an accruapl plan model to the time off app
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr