[IMP] stock_incoterm_extension: add default destination port #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oihane
force-pushed
the
8.0-incoterm
branch
2 times, most recently
from
2b74d8e
to
d18c3f7
Compare
Codecov Report
@@ Coverage Diff @@
## 8.0 #169 +/- ##
==========================================
+ Coverage 79.33% 79.55% +0.21%
==========================================
Files 54 54
Lines 847 856 +9
==========================================
+ Hits 672 681 +9
Misses 175 175
Continue to review full report at Codecov.
|
oihane
force-pushed
the
8.0-incoterm
branch
2 times, most recently
from
ec7c3c0
to
19eb12c
Compare
|
@odoomrp/developers please review
|
Daniel-CA
reviewed
May 28, 2018
| @api.model | ||
| def _create_invoice_from_picking(self, picking, vals): | ||
| if picking and picking.sale_id: | ||
| sale = picking.sale_id | ||
| if picking: |
There was a problem hiding this comment.
Ahora no se contempla que sea un picking con una venta asociada?
There was a problem hiding this comment.
Un picking puede tener o no venta, y puede tener un incoterm diferente, lo normal es que se traslade el de la venta y por ello se hace que sea con cualquiera.
Daniel-CA
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.