Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph popups are not sorted by value in descending order #1883

Closed
jagmeetb opened this issue Oct 13, 2018 · 0 comments · Fixed by #1890
Closed

Graph popups are not sorted by value in descending order #1883

jagmeetb opened this issue Oct 13, 2018 · 0 comments · Fixed by #1890
Assignees

Comments

@jagmeetb
Copy link
Contributor

jagmeetb commented Oct 13, 2018

Current Behavior
In the Graphs page of a match, mousing over any of the networth/xp/last-hits graphs produces a tooltip showing each player's value at that time in the game. These entries are ordered by the default player order (blue->teal->purple->...->brown)

Expected behavior/code
The entries should be ordered in descending order. ie. if the yellow player has the highest networth at 15 mins, mousing over the 15 min mark on the graph should create a tooltip where he is at the top.

This is how the graphs used to work but seems to be bugged for some time now. It would also mirror the functionality of the in-game graphs.

Console Output
none

Environment

  • Browser Version: Chrome Version 70.0.3538.54 (Official Build) beta (64-bit)
  • OS: Windows 7 Ultimate 64-bit

Additional context/Screenshots

In the following pic: TA (olive) is No.1 networth at 20 mins, so it should be at the top; Grimstroke (purple) should be at the bottom. The entries are instead sorted by player slot, from blue to brown
image

Also: I am trying to start contributing to open-source, and would like to tackle this issue myself!

jagmeetb added a commit to jagmeetb/web that referenced this issue Oct 13, 2018
howardchung added a commit that referenced this issue Oct 13, 2018
Fix #1883 - Add descending sort to tooltips on match graphs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant