Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge kokako #180

Merged
merged 129 commits into from
Mar 20, 2019
Merged

Merge kokako #180

merged 129 commits into from
Mar 20, 2019

Conversation

odow
Copy link
Owner

@odow odow commented Mar 13, 2019

Just a small diff.

This PR branches off the existing SDDP.jl into a release-v0 branch, and grafts on the existing Kokako.jl repository in its place.

Closes #6
Closes #10
Closes #28
Closes #29
Closes #36
Closes #62
Closes #70
Closes #79
Closes #80
Closes #84
Closes #88
Closes #92
Closes #96
Closes #107
Closes #115
Closes #118
Closes #124
Closes #149
Closes #150
Closes #156
Closes #158
Closes #162
Closes #166
Closes #172
Closes #175
Closes #176
Closes #182
Closes #183
Closes #184

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #180 into master will increase coverage by 0.2%.
The diff coverage is 89.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #180     +/-   ##
=========================================
+ Coverage   89.37%   89.57%   +0.2%     
=========================================
  Files          31       11     -20     
  Lines        1430      863    -567     
=========================================
- Hits         1278      773    -505     
+ Misses        152       90     -62
Impacted Files Coverage Δ
src/SDDP.jl 100% <ø> (+1.26%) ⬆️
src/visualization/publication_plot.jl 20% <20%> (ø)
src/plugins/headers.jl 45.45% <45.45%> (ø)
src/visualization/spaghetti_plot.jl 58.06% <58.06%> (ø)
src/plugins/sampling_schemes.jl 70% <70%> (ø)
src/plugins/risk_measures.jl 86.31% <86.31%> (ø)
src/plugins/stopping_rules.jl 92.85% <92.85%> (ø)
src/print.jl 95.55% <95.55%> (-4.45%) ⬇️
src/plugins/bellman_functions.jl 95.93% <95.93%> (ø)
src/user_interface.jl 96.87% <96.87%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85afbf...8e7c537. Read the comment docs.

@odow
Copy link
Owner Author

odow commented Mar 20, 2019

Once CI finishes I'm going to hit merge and then deal with the resulting fallout of people running Pkg.update() on 0.6.

@odow odow merged commit cf24ced into master Mar 20, 2019
@odow odow deleted the merge_kokako branch March 20, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant