Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: register Gcloud Iam roles as configurable roles in provider config #223

Merged
merged 10 commits into from
Aug 10, 2022
Merged

feat: register Gcloud Iam roles as configurable roles in provider config #223

merged 10 commits into from
Aug 10, 2022

Conversation

utsav14nov
Copy link
Contributor

No description provided.

@bsushmith
Copy link
Member

@utsav-agarwal can you fix the test cases and lint errors

@ravisuhag ravisuhag changed the title feat: Registerd Gcloud Iam roles as resources of guardian feat: register Gcloud Iam roles as resources of guardian Jul 21, 2022
@rahmatrhd
Copy link
Member

@utsav14nov need to understand the use case of this, let's discuss in #218

@coveralls
Copy link

coveralls commented Jul 21, 2022 •
edited

Pull Request Test Coverage Report for Build 2830995404

  • 44 of 54 (81.48%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 75.909%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/providers/gcloudiam/client.go 0 2 0.0%
plugins/providers/gcloudiam/config.go 26 30 86.67%
plugins/providers/gcloudiam/provider.go 18 22 81.82%
Totals Coverage Status
Change from base Build 2816532060: 0.1%
Covered Lines: 5325
Relevant Lines: 7015
💛 - Coveralls

@utsav14nov
Copy link
Contributor Author

@utsav-agarwal can you fix the test cases and lint errors

@bsushmith Test cases and lint is fixed

@utsav14nov
Copy link
Contributor Author

@utsav14nov need to understand the use case of this, let's discuss in #218

@rahmatrhd
Please check #218 (comment)

@ravisuhag ravisuhag linked an issue Jul 25, 2022 that may be closed by this pull request
Ability to configure roles for gcloud_iam provider #184
Closed
@ravisuhag ravisuhag removed a link to an issue Jul 25, 2022
Ability to configure roles for gcloud_iam provider #184
Closed
@ravisuhag ravisuhag linked an issue Jul 25, 2022 that may be closed by this pull request
Able to register gcp iam roles as resources #218
Closed
@utsav14nov utsav14nov marked this pull request as draft July 27, 2022 05:17
@utsav14nov utsav14nov marked this pull request as ready for review July 28, 2022 08:56
bsushmith
bsushmith reviewed Jul 28, 2022
View reviewed changes
plugins/providers/gcloudiam/provider.go Outdated Show resolved Hide resolved
plugins/providers/gcloudiam/provider.go Outdated Show resolved Hide resolved
plugins/providers/gcloudiam/provider.go Outdated Show resolved Hide resolved
@singhvikash11 singhvikash11 mentioned this pull request Jul 28, 2022
Closed
rahmatrhd
rahmatrhd requested changes Jul 31, 2022
View reviewed changes
plugins/providers/gcloudiam/errors.go Outdated Show resolved Hide resolved
plugins/providers/gcloudiam/provider.go Outdated Show resolved Hide resolved
plugins/providers/gcloudiam/provider.go Outdated Show resolved Hide resolved
@bsushmith bsushmith mentioned this pull request Aug 1, 2022
Closed
@bsushmith
Copy link
Member

@utsav-agarwal overall code test coverage decreased. Can you check and add test cases if missing for any flow?

rahmatrhd
rahmatrhd requested changes Aug 9, 2022
View reviewed changes
plugins/providers/gcloudiam/config.go Outdated Show resolved Hide resolved
plugins/providers/gcloudiam/provider.go Outdated Show resolved Hide resolved
plugins/providers/gcloudiam/provider.go Outdated Show resolved Hide resolved
@utsav14nov
Copy link
Contributor Author

@bsushmith Overall test coverage is fixed.

rahmatrhd
rahmatrhd approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@rahmatrhd rahmatrhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bsushmith bsushmith self-requested a review August 10, 2022 08:03
@ravisuhag ravisuhag merged commit 4d1fca7 into main Aug 10, 2022
@ravisuhag ravisuhag deleted the gcloud_iam_roles_resources branch August 10, 2022 08:07
@rahmatrhd rahmatrhd changed the title feat: register Gcloud Iam roles as resources of guardian feat: register Gcloud Iam roles as configurable roles in provider config Aug 26, 2022
lifosmin pushed a commit to lifosmin/guardian that referenced this pull request Aug 31, 2023
@sudo-suhas
feat!: support multiple model versions in a single asset (raystack#223)
5267e1f 
BREAKING CHANGES: Structure of Model proto is changed in a backward
incompatible manner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh mabdh left review comments

@rahmatrhd rahmatrhd rahmatrhd approved these changes

@bsushmith bsushmith bsushmith approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@singhvikash11 singhvikash11 Awaiting requested review from singhvikash11

Assignees
No one assigned
Labels
gcloud_iam provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Able to register gcp iam roles as resources
6 participants
@utsav14nov @bsushmith @rahmatrhd @coveralls @mabdh @ravisuhag