Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: meteor "new recipe" command is not using latest recipe requirement #402

Closed
StewartJingga opened this issue Aug 29, 2022 · 1 comment · Fixed by #405
Closed

bug: meteor "new recipe" command is not using latest recipe requirement #402

StewartJingga opened this issue Aug 29, 2022 · 1 comment · Fixed by #405

Comments

@StewartJingga
Copy link
Contributor

StewartJingga commented Aug 29, 2022

Describe the bug
Current meteor new command does not use the latest recipe requirements.

generated-recipe.yaml

name: sample
version: v1beta1
source:
  type: kafka
  config:     
    broker: "my-broker:6668"
sinks:
  - name: http
    config:       
      # The url (hostname and route) of the http service
      url: http://localhost:3333
      method: POST
      # Additional HTTP headers, multiple headers value are separated by a comma
      headers:
        X-Other-Header: value1, value2

running this get below error

ERRO[0000] error running recipe                          duration_ms=0 err="failed to setup extractor: could not initiate extractor \"kafka\": urn scope is required to generate unique urn" recipe=sample records_count=0
ERRO[0000] failed to setup extractor: could not initiate extractor "kafka": urn scope is required to generate unique urn

The error is because since version 0.5.0, meteor introduce new required source.scope field on recipe.
This field is needed to make sure asset's urn is unique by using scope as some sort of namespacing feature.

To Reproduce
Steps to reproduce the behavior:

  1. Run meteor new recipe sample -e kafka -s http > recipe.yaml
  2. Copy printed out recipe to a file (recipe.yaml)
  3. Run meteor run recipe.yaml
  4. See error

Expected behavior

Update new command

meteor new recipe should include scope on the generated recipe. It could also make scope as part of required input when running the command. e.g. --scope=my-scope.

Docs updated

Somewhere in the docs, it would be helpful if the new scope field is being mentioned so that users are not stuck.

@StewartJingga StewartJingga changed the title bug: recipe generator is not using latest recipe requirement bug: meteor "new recipe" command is not using latest recipe requirement Aug 29, 2022
@sudo-suhas
Copy link
Contributor

Related PR - #406.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants