fix: avoid race conditions from concurrent modification of data #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
force-pushed
the
avoid-race-conditions
branch
2 times, most recently
from
d1dcd9d
to
c7d9fda
Compare
sudo-suhas
force-pushed
the
avoid-race-conditions
branch
2 times, most recently
from
aceb48b
to
3678417
Compare
- Use atomic int for incrementing record count in agent run. - Protect fields that can be concurrently modified in a stream instance using a mutex. - Avoid referring to and modification of errors or values declared outside closures.
sudo-suhas
force-pushed
the
avoid-race-conditions
branch
from
3678417
to
ba4fad2
Compare
StewartJingga
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't modify slice to collect runs concurrently while running multiple recipes in agent. Use channels to collect runs instead.