Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed APIs that are replaced by relation APIs #240

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

ishanarya0
Copy link
Member

The following API routes shall go away, as shield now have relation APIs.

RESOURCE

AddTeamToResource
AddOwnerToResource

GROUP

AddUsers 
RemoveUser 
AddAdmins 
RemoveAdmin 
ListGroupUsers 
ListGroupAdmins 

ORGANIZATION

AddAdmins
RemoveAdmin

PROJECT

AddAdmins
RemoveAdmin

@ishanarya0 ishanarya0 marked this pull request as draft January 18, 2023 06:45
@ishanarya0 ishanarya0 changed the title refactor: removed some group api refactor: removed APIs that are replaced by relation APIs Jan 18, 2023
@ishanarya0 ishanarya0 marked this pull request as ready for review January 18, 2023 08:26
@krtkvrm krtkvrm merged commit e75b207 into main Jan 31, 2023
@krtkvrm krtkvrm deleted the shield-api-cleanup branch January 31, 2023 04:16
@kushsharma
Copy link
Member

Wanted to understand the thought process behind keeping relations API and removing all these. Was the idea behind making it more flexible? If yes, what if we keep these specific APIs along with relation API? Because now the burden of converting these basic domain-level requests from generic relations comes to clients.

We could behind the scenes convert these basic use cases to relations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants