Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for namespace in compass #246

Merged
merged 1 commit into from
Mar 18, 2023
Merged

feat: support for namespace in compass #246

merged 1 commit into from
Mar 18, 2023

Conversation

kushsharma
Copy link
Member

Compass is a single-tenant application, to make it multi-tenant just like most odpf applications few breaking changes are introduced.

@kushsharma kushsharma force-pushed the compass-namespace branch 3 times, most recently from 39707f7 to 69bc9a1 Compare February 27, 2023 10:24
@kushsharma kushsharma marked this pull request as ready for review February 28, 2023 08:27
@kushsharma kushsharma mentioned this pull request Feb 28, 2023
Merged
@kushsharma kushsharma force-pushed the compass-namespace branch 2 times, most recently from 1bd8bf4 to 106d7de Compare March 10, 2023 16:54
@rohilsurana
Copy link
Member

Any specific reason to go with namespace as the variable for tenants. Can we instead use project as we want to isolate on basis of project?

@kushsharma
Copy link
Member Author

I am okay with project as GCP uses the same term, as long as we standardize the terminology across all products. Although I have seen namespace term being used for multi-tenancy as well quite a lot.

@ravisuhag
Copy link
Member

Agree that projects can be very specific. I think namespace or workspace are better choice.

@kushsharma
feat: support for namespace in compass
eeec3f3 
namespace will be extracted from the headers, if not
passed should fall back to default namespace

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@ravisuhag ravisuhag merged commit e6f19a8 into main Mar 18, 2023
@ravisuhag ravisuhag deleted the compass-namespace branch March 18, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudo-suhas sudo-suhas Awaiting requested review from sudo-suhas

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

@mabdh mabdh Awaiting requested review from mabdh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushsharma @rohilsurana @ravisuhag