Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add e2e test bench #152

Merged
merged 4 commits into from
Aug 19, 2022
Merged

feat: add e2e test bench #152

merged 4 commits into from
Aug 19, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Aug 12, 2022 •
edited
Loading

Add utility to do end-to-end test

  • Spin up 2 Postgres and 1 Spice DB in such a way that they are connected
  • All are being done programmatically with dockertest
  • Once all DBs are up, run shield migration and shield server with cobra cli

@coveralls
Copy link

coveralls commented Aug 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2888214370

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.195%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/serve.go 0 1 0.0%
cmd/server.go 0 1 0.0%
Totals Coverage Status
Change from base Build 2887226770: 0.0%
Covered Lines: 3454
Relevant Lines: 7021
💛 - Coveralls

@mabdh mabdh marked this pull request as ready for review August 12, 2022 10:39
@mabdh mabdh mentioned this pull request Aug 12, 2022
Closed
@mabdh mabdh linked an issue Aug 13, 2022 that may be closed by this pull request
Shield end-to-end test #138
Closed
@rohilsurana
Copy link
Member

Haven't looked at the actual test data. But code wise looks good to me.

@mabdh
Copy link
Member Author

mabdh commented Aug 16, 2022

Testdata in this PR consist of:

  • Creating 1 organization, 1 project
  • Creating 3 groups assigned to the organization
  • Each group will have 3 users (created 9 users) and one of them is admin
    • So a group consist of 1 admin and 2 members

@mabdh mabdh merged commit 17e8ca7 into main Aug 19, 2022
@mabdh mabdh deleted the end-to-end-test branch August 19, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krtkvrm krtkvrm krtkvrm approved these changes

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija

@rohilsurana rohilsurana Awaiting requested review from rohilsurana

@spy16 spy16 Awaiting requested review from spy16

@rsbh rsbh Awaiting requested review from rsbh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shield end-to-end test
4 participants
@mabdh @coveralls @rohilsurana @krtkvrm