Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

using bearer token authorization #98

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Conversation

bogdan-sava
Copy link
Contributor

No description provided.

Signed-off-by: Bogdan Sava <bogdan.sava@gmail.com>
Copy link
Member

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test the contents, but do approve that we need this change for v4
For testing with containers we will need a new UI container image/version to be kicked off - either a prerelease for testing, or a final version if happy enough testing has been done

Signed-off-by: Bogdan Sava <bogdan.sava@gmail.com>
@sarbull
Copy link
Member

sarbull commented Mar 30, 2023

@bogdan-sava why was this merged if the build failed?

@bogdan-sava
Copy link
Contributor Author

the build was successful

@bogdan-sava
Copy link
Contributor Author

@sarbull
Copy link
Member

sarbull commented Mar 30, 2023

Screenshot 2023-03-30 at 14 37 27

@sarbull
Copy link
Member

sarbull commented Mar 30, 2023

@bogdan-sava i saw the commit named "fixed tests", it updated the other commit, it's ok

@bogdan-sava
Copy link
Contributor Author

that was fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants