Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Updates to Docker build #108

Closed
planetf1 opened this issue Mar 19, 2021 · 3 comments
Closed

Updates to Docker build #108

planetf1 opened this issue Mar 19, 2021 · 3 comments
Assignees

Comments

@planetf1
Copy link
Member

Several changes are needed to the docker build now that we are doing in the same repo

  1. Switch to node 10 (not 14 -- which is failing to work properly)
  2. Avoid re-cloning the source and building from scratch, which was previously needed as the dockerfile was in the egeria repo
@planetf1 planetf1 self-assigned this Mar 19, 2021
planetf1 added a commit to planetf1/egeria-ui that referenced this issue Mar 19, 2021
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue Mar 19, 2021
#108 Switch to node 10 in Docker build
@planetf1 planetf1 reopened this Mar 20, 2021
planetf1 added a commit to planetf1/egeria-ui that referenced this issue Mar 20, 2021
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1
Copy link
Member Author

I have considered the current build process and propose another change

The prior approach was based on a self-building image where, when we built the container, we extracted from git and built locally.
This was because we were running the docker build in a different repo/pipeline to the UI node build.

Now that the docker file and code are co-located, there is no need to build twice.

Instead we can simply copy the output files across into the container.

See

planetf1 added a commit to planetf1/egeria-ui that referenced this issue Mar 20, 2021
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue Mar 20, 2021
#108 Improve docker build by reusing pipeline build
planetf1 added a commit to planetf1/egeria-ui that referenced this issue Mar 20, 2021
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
sarbull added a commit that referenced this issue Mar 20, 2021
#108 revert incorrect update to package-lock.json
@sarbull
Copy link
Member

sarbull commented Mar 26, 2021

@planetf1 can we close this?

@planetf1
Copy link
Member Author

Yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants