Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Initial feedback on building egeria-ui #7

Closed
planetf1 opened this issue Oct 14, 2020 · 2 comments
Closed

Initial feedback on building egeria-ui #7

planetf1 opened this issue Oct 14, 2020 · 2 comments
Assignees

Comments

@planetf1
Copy link
Member

  • After an 'npm install' and 'npm run build' a 'git status' is showing package-lock.json as having been modified

    • is this intentional
  • To build, it seems as if 'npm install polymer-cli' is needed

  • On macOS, and in an alpine 14 container on docker, a 'npm test' is failing with:

jonesn:egeria-ui/ (master*) $ npm test                                                                                [15:59:49]

> egeria-ui@0.0.1 test /Users/jonesn/IdeaProjects/egeria-ui
> polymer test


TypeError: Cannot read property 'length' of undefined

error:	cli runtime exception: TypeError: Cannot read property 'length' of undefined
error:	TypeError: Cannot read property 'length' of undefined
    at /usr/local/lib/node_modules/polymer-cli/node_modules/web-component-tester/runner/webserver.js:93:142
    at Generator.next (<anonymous>)
    at /usr/local/lib/node_modules/polymer-cli/node_modules/web-component-tester/runner/webserver.js:20:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/local/lib/node_modules/polymer-cli/node_modules/web-component-tester/runner/webserver.js:16:12)
    at /usr/local/lib/node_modules/polymer-cli/node_modules/web-component-tester/runner/webserver.js:63:16
    at /usr/local/lib/node_modules/polymer-cli/node_modules/web-component-tester/runner/context.js:107:42
    at new Promise (<anonymous>)
    at hookToPromise (/usr/local/lib/node_modules/polymer-cli/node_modules/web-component-tester/runner/context.js:106:24)
    at Context.<anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/web-component-tester/runner/context.js:124:27)
npm ERR! Test failed.  See above for more details.
jonesn:egeria-ui/ (master*) $ 

@sarbull
Copy link
Member

sarbull commented Oct 14, 2020

Merging #8 will adds the following:

  • makes the package independent of operating system, any script command will work only after runing npm install because of adding missing packages under devDependencies(this is explained here [0]) in package.json.
  • npm run build (now with prod build, minify for html, css and js)
  • npm run lint
  • npm test (only chrome is being checked)
  • npm start (default start on 8081 using polymer serve command)
  • npm run start:dev (uses the polymer serve command with some arguments and proxies everything that's under /api to the mock, if it's not under /api it won't work and you need to use the npm run serve command, due to polymer cli contraints)

[0] - https://stackoverflow.com/a/48826003

@sarbull
Copy link
Member

sarbull commented Oct 16, 2020

@planetf1 this can be closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants