This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Add missing dependencies and fix test command #7 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarbull
changed the title
Signed-off-by: Sirbu Nicolae-Cezar <sirbunicolaecezar@gmail.com>
Signed-off-by: Sirbu Nicolae-Cezar <sirbunicolaecezar@gmail.com>
Signed-off-by: Sirbu Nicolae-Cezar <sirbunicolaecezar@gmail.com>
Signed-off-by: Sirbu Nicolae-Cezar <sirbunicolaecezar@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this will adds the following:
npm installbecause of adding missing packages underdevDependencies(this is explained here [0]) inpackage.json.npm run build(now with prod build, minify for html, css and js)npm run lintnpm test(only chrome is being checked)npm start(default start on 8081 usingpolymer servecommand)npm run start:dev(uses thepolymer servecommand with some arguments and proxies everything that's under /api to the mock, if it's not under /api it won't work and you need to use thenpm run servecommand, due to polymer cli contraints)[0] - https://stackoverflow.com/a/48826003
Signed-off-by: Sirbu Nicolae-Cezar sirbunicolaecezar@gmail.com