-
Notifications
You must be signed in to change notification settings - Fork 17
Check for package-version-updated #261
Check for package-version-updated #261
Conversation
c5999df
to
c4f5c2e
Compare
Signed-off-by: Sirbu Nicolae-Cezar <sirbunicolaecezar@gmail.com>
c4f5c2e
to
c70ee0d
Compare
The solution seems good to me & most importantly fixes the major image overriding issue we had. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved (see comment)
- name: Login to container registry (Quay.io) | ||
uses: docker/login-action@v1 | ||
with: | ||
registry: quay.io | ||
username: ${{ secrets.QUAY_IO_USERNAME }} | ||
password: ${{ secrets.QUAY_IO_ACCESS_TOKEN }} | ||
if: ${{ github.event_name == 'push' && github.repository == 'odpi/egeria-ui' }} | ||
if: ${{ steps.check.outputs.changed == 'true' && github.event_name == 'push' && github.repository == 'odpi/egeria-ui' }} | ||
# For releases (ie not main) we push the image - but not the latest tag | ||
- name: Build and push (not master merge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are not using release branches this block (61:70) is obsolete and can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, but let's do that in a different iteration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good - We have the ability to do pre-release updates whenever we wish within the development cycle (to align with egeria master for example) as well as keep a stable release.
Signed-off-by: Sirbu Nicolae-Cezar sirbunicolaecezar@gmail.com
LATER EDIT
Also, we can use this command so that we create a snapshot version in order to prepare a release and it will run the docker pipeline because it will sense a version change, in this way it will start the docker pipeline creating the required image.
After N number of snapshots when we'll bump the version it will look like this, here is an example of a patch after a couple of snapshots.
Without version change:
![Screenshot 2021-10-25 at 19 02 16](https://user-images.githubusercontent.com/1864112/138730444-1e95eecb-8e14-4432-bb76-a5f6ee706824.png)
With version change:
![Screenshot 2021-10-25 at 19 06 24](https://user-images.githubusercontent.com/1864112/138731190-8e28bb4e-4187-457d-89e8-00336ede3e0a.png)