Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect logging of exception in Kafka Connector #5028

Closed
mandy-chessell opened this issue Apr 6, 2021 · 5 comments
Closed

Incorrect logging of exception in Kafka Connector #5028

mandy-chessell opened this issue Apr 6, 2021 · 5 comments
Assignees
Labels
consumability Makes the software easier to use or understand. Includes docs, error messages, logs, API definitions no-issue-activity Issues automatically marked as stale because they have not had recent activity.

Comments

@mandy-chessell
Copy link
Contributor

Issue #4952 describes a situation where an exception is coming from Apache Kafka that is causing the connector to end abnormally and the exception is being logging through SLF4J rather tthan the audit log.

@mandy-chessell
Copy link
Contributor Author

This is the offending code in KafkaOpenMetadataEventProducer:

            catch (Throwable   error)
            {
                log.error("Bad exception from sending events " + error.getMessage());

                if( isExceptionRetryable(error) ) {
                    this.recoverAfterError();
                }
                else {

                    /* This is an unrecoverable error so clean up and shutdown*/
                    break;
                }
            }

@mandy-chessell mandy-chessell added the consumability Makes the software easier to use or understand. Includes docs, error messages, logs, API definitions label Apr 6, 2021
@planetf1
Copy link
Member

@wbittles Do you want to look at this?

@wbittles
Copy link
Contributor

After some investigation I changed the proposed fix for this issue and created a new PR.
The above code is only executed when exceptions have been encountered and audit log entries should have already been called.
I believe I've traced the offending piece of code and added the missing audit logs entries.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Jul 30, 2021
@planetf1
Copy link
Member

Closing as this looks to be complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumability Makes the software easier to use or understand. Includes docs, error messages, logs, API definitions no-issue-activity Issues automatically marked as stale because they have not had recent activity.
Projects
None yet
Development

No branches or pull requests

3 participants