Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclosed client session when calling get_oauth_token #40

Closed
alenpaulvarghese opened this issue May 25, 2021 · 3 comments
Closed

Unclosed client session when calling get_oauth_token #40

alenpaulvarghese opened this issue May 25, 2021 · 3 comments

Comments

@alenpaulvarghese
Copy link
Contributor

Expected behavior

A graceful shutdown.

Actual behavior

calling
get_oauth_token

when trying to close

Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fb325b04ee0>

version

python - 1.9.5
peony-twitter - latest
odrling added a commit that referenced this issue May 25, 2021
@odrling
oauth_dance: close client session cleanly #40
32bf8dd
@alenpaulvarghese
Copy link
Contributor Author

thank you for fixing it 👍

@odrling
Copy link
Owner

odrling commented May 25, 2021 •
edited
Loading

I think that should work fine with the latest commit.
Though I somehow don't get this message when calling these functions before this commit.
EDIT: Oh thanks for testing then.

@alenpaulvarghese
Copy link
Contributor Author

I think that should work fine with the latest commit.
Though I somehow don't get this message when calling these functions before this commit.
EDIT: Oh thanks for testing then.

Thanks its working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odrling @alenpaulvarghese