a fix for failed downloads during imagereel generation

oduwsdl · Jun 5, 2020 · a0206ca · a0206ca
1 parent 30eef5f
commit a0206ca
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/docs/source/conf.py b/docs/source/conf.py
@@ -26,7 +26,7 @@
 # The short X.Y version
 version = ''
 # The full version, including alpha/beta/rc tags
-release = '0.2020.05.08.220018'
+release = '0.2020.06.05.214724'
 
 
 # -- General configuration ---------------------------------------------------

diff --git a/mementoembed/mementoimagereel.py b/mementoembed/mementoimagereel.py
@@ -63,7 +63,15 @@ def generate_imagereel(self, urim, duration, countlimit, requested_width, reques
 
             for imageuri in [ i[1] for i in sorted(scorelist, reverse=True) ]:
 
-                r = self.httpcache.get(imageuri)
+                try:
+
+                    r = self.httpcache.get(imageuri)
+
+                except Exception:
+
+                    module_logger.exception("failed to download image at {}, skipping".format(imageuri))
+                    continue
+
                 ifp = io.BytesIO(r.content)
 
                 baseims.append( 

diff --git a/mementoembed/textprocessing.py b/mementoembed/textprocessing.py
@@ -27,6 +27,12 @@ class SnippetGenerationError(TextProcessingError):
 
 def get_text_without_boilerplate(htmlcontent):
 
+    # Note: this boilerplate method did not work for archive.is
+
+    # from boilerpy3 import extractors
+    # extractor = extractors.ArticleExtractor()
+    # bpfree = extractor.get_content(htmlcontent)
+    # return bpfree
     # htmlcontent = htmlcontent.replace('\n', ' ')
 
     try:

diff --git a/mementoembed/version.py b/mementoembed/version.py
@@ -1,3 +1,3 @@
 __appname__ = "MementoEmbed"
-__appversion__ = '0.2020.05.08.220018'
+__appversion__ = '0.2020.06.05.214724'
 __useragent__ = "{}/{}".format(__appname__, __appversion__)