Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually verify that images exist before using them as a striking image #30

Closed
shawnmjones opened this issue Jun 13, 2018 · 3 comments
Closed

Actually verify that images exist before using them as a striking image #30

shawnmjones opened this issue Jun 13, 2018 · 3 comments
Assignees
@shawnmjones
Labels
bug Something isn't working

Comments

@shawnmjones
Copy link
Member

Sometimes the image returned generates a 404. This could be a temporary archive issue, but we should assume that it just wasn't crawled and isn't available.
@shawnmjones shawnmjones added the bug Something isn't working label Jun 13, 2018
@shawnmjones shawnmjones added this to the Version 0.1 milestone Jun 13, 2018
@shawnmjones shawnmjones self-assigned this Jun 13, 2018
@ibnesayeed
Copy link
Member

ibnesayeed commented Jun 14, 2018 •
edited

If this ticket is about the missing thumbnail image in the card, then looking into the JS console could be helpful to identify the source of the issue. The missing resource seems to be fetched from http://localhost:5550/undefined.

@shawnmjones
Copy link
Member Author

That is a new problem. Thanks for noting it and please submit it as a new issue.

@ibnesayeed ibnesayeed mentioned this issue Jun 14, 2018
Closed
@shawnmjones
Copy link
Member Author

I'm rewriting the image selection algorithm to address this and other issues.

shawnmjones added a commit that referenced this issue Jun 16, 2018
@shawnmjones
some work on #30, #13 for selecting good images
d76ad13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnmjones shawnmjones

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibnesayeed @shawnmjones