Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the build of the library index #246

Merged
merged 2 commits into from
May 26, 2023
Merged

Rework the build of the library index #246

merged 2 commits into from
May 26, 2023

Conversation

gregdel
Copy link
Member

@gregdel gregdel commented May 25, 2023

No description provided.

@gregdel gregdel requested a review from PouuleT May 25, 2023 20:12
@coveralls
Copy link

coveralls commented May 25, 2023 •
edited

Pull Request Test Coverage Report for Build 5088565441

  • 79 of 113 (69.91%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 67.613%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/library/index.go 69 103 66.99%
Files with Coverage Reduction New Missed Lines %
lib/library/index.go 2 71.24%
Totals Coverage Status
Change from base Build 4358695543: -0.02%
Covered Lines: 2666
Relevant Lines: 3943
💛 - Coveralls

@gregdel
Add a IsVideo method on the file config
9a032ca 
This is a small optimisation to avoid searching the whole array every
time.
@PouuleT PouuleT merged commit 70aa05a into master May 26, 2023
3 of 4 checks passed
@PouuleT PouuleT deleted the library-index branch May 26, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PouuleT PouuleT Awaiting requested review from PouuleT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gregdel @coveralls @PouuleT