Skip to content

Commit

Permalink
Fix bad variant access (#341)
Browse files Browse the repository at this point in the history
* fix bad variant access when quill is already compiled
  • Loading branch information
odygrd committed Aug 9, 2023
1 parent c995a02 commit 9a270d5
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- [v3.3.2](#v332)
- [v3.3.1](#v331)
- [v3.3.0](#v330)
- [v3.2.0](#v320)
Expand Down Expand Up @@ -50,6 +51,14 @@
- [v1.1.0](#v110)
- [v1.0.0](#v100)

## v3.3.2

- Resolved "bad_variant_access" error occurring when using Quill as a pre-compiled library with a distinct queue
type. ([#276](https://github.com/odygrd/quill/pull/276))

- Resolved a bug in `RotatingFileHandler` associated with logfiles located outside the working directory,
specifically when used with open_mode `a`. ([#340](https://github.com/odygrd/quill/pull/340))

## v3.3.1

- Fixed `RotatingFileHandler` to prevent accidental removal of non-log files when using open mode `w`
Expand Down
4 changes: 2 additions & 2 deletions quill/include/quill/Quill.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace quill
/** Version Info **/
constexpr uint32_t VersionMajor{3};
constexpr uint32_t VersionMinor{3};
constexpr uint32_t VersionPatch{1};
constexpr uint32_t VersionPatch{2};
constexpr uint32_t Version{VersionMajor * 10000 + VersionMinor * 100 + VersionPatch};

/** forward declarations **/
Expand Down Expand Up @@ -322,7 +322,7 @@ void remove_logger(Logger* logger);
*
* @note This function will not do anything if called while the backend worker is not running
*/
void flush();
inline void flush() { detail::LogManagerSingleton::instance().log_manager().flush(); }

/**
* Wakes up the backend logging thread on demand.
Expand Down
3 changes: 0 additions & 3 deletions quill/src/Quill.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,6 @@ void remove_logger(Logger* logger)
detail::LogManagerSingleton::instance().log_manager().logger_collection().remove_logger(logger);
}

/***/
void flush() { detail::LogManagerSingleton::instance().log_manager().flush(); }

/***/
void wake_up_logging_thread()
{
Expand Down

0 comments on commit 9a270d5

Please sign in to comment.