timestamp formatting bug (#336)

CHANGELOG.md

@@ -81,6 +81,9 @@
   Quill ERROR: [format: "Support for floats {:.{}f}", error: "precision is not integer"]
   ```
 
+- Fixed a bug in timestamp formatting that occasionally displayed an hour component of 24 as
+  0. ([#329](https://github.com/odygrd/quill/pull/329))
+
 - Added support for specifying a runtime log level, allowing dynamic log level configuration at runtime.
   The new runtime log level feature provides flexibility when needed, with a minor overhead cost.
   It is recommended to continue using the existing static log level macros for optimal

README.md

@@ -426,6 +426,14 @@ To build Quill as a shared library (DLL) on Windows, follow these steps:
 2. Additionally, you need to define `QUILL_BUILD_SHARED` either in your code before including `Quill.h` or as a compiler
    flag when building outside of CMake.
 
+#### Building Quill for Android NDK
+
+To build Quill for Android NDK add the following CMake flags when configuring the build:
+
+  ```
+  -DQUILL_NO_THREAD_NAME_SUPPORT:BOOL=ON
+  ```
+
 ## Design
 
 ![design.jpg](docs%2Fdesign.jpg)

quill/include/quill/handlers/Handler.h

@@ -43,6 +43,7 @@ class Handler
 
   /**
    * Set a custom formatter for this handler
+   * @note This function is not thread safe and should be called before any logging to this handler happens
    * @param format_pattern format pattern see PatternFormatter
    * @param timestamp_format defaults to "%H:%M:%S.%Qns"
    * @param timezone defaults to PatternFormatter::Timezone::LocalTime

quill/src/detail/backend/StringFromTime.cpp

@@ -136,13 +136,12 @@ std::string const& StringFromTime::format_timestamp(time_t timestamp)
     _pre_formatted_ts.clear();
     _cached_indexes.clear();
 
-    // Now populate a pre formatted string for the next rec
+    // Now populate a pre-formatted string for the next rec
     _populate_pre_formatted_string_and_cached_indexes(timestamp);
 
     if (_time_zone == Timezone::LocalTime)
     {
-      // Update the timestamp to point to the next hour, here we can just add 3600 as the _next_hour_timestamp was already rounded to point to sharp minutes before
-      _next_recalculation_timestamp = timestamp + 3600;
+      _next_recalculation_timestamp = next_hour_timestamp(timestamp);
     }
     else if (_time_zone == Timezone::GmtTime)
     {

quill/test/QuillLogTest.cpp

@@ -160,9 +160,9 @@ TEST_CASE("log_from_const_function")
     // log again for class b
     log_test_class const log_test_class_b{filename};
     log_test_class_b.use_logger_const();
-  }
 
-  quill::flush();
+    quill::flush();
+  }
 
   // Read file and check
   std::vector<std::string> const file_contents = quill::testing::file_contents(filename);