RotatingFileHandler: Store complete path in '_created_files' #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously _created_files had been mixed. Sometimes the full path was stored and sometimes only the filename. The problem with the filename only method was that there are cases where the logfile is not in the current working directory. Quill failed to rename that file in those cases. Basically quill::detail::rename_file() failed sometimes in _rotate_files() and showed an error on the console for files that did not exist.
|
Thanks for the PR! : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously '_created_files' sometimes stored the full path and sometimes only the filename. This PR fixes that.
The problem is that the logfile is not always located in the working directory.
Basically quill::detail::rename_file() failed sometimes in _rotate_files() and showed an error on the console for the filename-only-files.
Also changed the hardcoded .log extension to fs::extension(). ;)