Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore the last window size? #5

Open
Hessen525 opened this issue Feb 24, 2020 · 1 comment
Open

ignore the last window size? #5

Hessen525 opened this issue Feb 24, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Hessen525
Copy link

Hi, @OdysseasKr
Thanks for your work. gen_batch(chunk.iloc[:,1], chunk.iloc[:,0], chunk.shape[0]-window_size, 0, window_size) in gen.py. Why not chunk.shape[0]-window_size+1?

ex: batch size: 5, window_size = 2, the number of sliding windows should be 5-2+1=4 if I understand correctly,

Thanks.

@OdysseasKr OdysseasKr added the bug Something isn't working label Mar 1, 2020
@OdysseasKr
Copy link
Owner

You are indeed correct on that, I will fix that as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants