Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for ACL #12

Merged
merged 3 commits into from
May 23, 2015
Merged

Conversation

njj
Copy link
Contributor

@njj njj commented May 22, 2015

This gives the ability to pass other ACL parameters i.e. public-read, while still being backwards compatible and falling back to private if no option is present.

@njj njj mentioned this pull request May 22, 2015
@@ -53,7 +54,7 @@ function S3Router(options) {
Key: fileKey,
Expires: 60,
ContentType: mimeType,
ACL: 'private'
ACL: options.ACL ? options.ACL : 'private'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options.ACL || 'private' would be good.

@seanadkinson
Copy link
Contributor

Thanks for the PR. Mind adding this option as an example to the README.md? Something like:

app.use('/s3', require('react-s3-uploader/s3router')({
    bucket: "MyS3Bucket",
    ACL: 'private'  // this is the default
}));

seanadkinson added a commit that referenced this pull request May 23, 2015
@seanadkinson seanadkinson merged commit 931ccd8 into odysseyscience:master May 23, 2015
@seanadkinson
Copy link
Contributor

Pushed version 1.1.10 with this update. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants