Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMDb] Downloader.py #528

Closed
jbleyel opened this issue Jul 3, 2022 · 0 comments · Fixed by #546
Closed

[IMDb] Downloader.py #528

jbleyel opened this issue Jul 3, 2022 · 0 comments · Fixed by #546
Labels
enhancement

Comments

@jbleyel
Copy link
Contributor

jbleyel commented Jul 3, 2022

Remove usage of Downloader.py / downloadWithProgress because this is not needed.
Use requests or any other http downloader.
@jbleyel jbleyel changed the title [IMDb] [IMDb] Downloader.py Jul 3, 2022
adoxa added a commit to adoxa/enigma2-plugins that referenced this issue Sep 12, 2022
@adoxa
[imdb] Big update
84e9afe 
Replace the regex searches with JSON data that's included in the page,
including the translations provided by IMDb.  The storyline & tagline
are downloaded separately.

Use requests for downloads (resolves oe-alliance#528); update the dependents.

Press MEDIA to download and display a bigger poster; press TEXT to
display a synopsis (if available; this may require a skin change to add
"VKeyIcon").

Save is always available (parameter still exists, but is ignored), using
"/home/root/logs/imdb" if no path is specified.  Use "-TITLEID" instead
of ".imdbquery2".  HTML will save the poster; text will be similar to
how it's displayed; text with poster will use the big poster if it's
been downloaded, otherwise the full-size poster will be retrieved.

quoteEventName stopped using the safe list, remove it.

Add new parameter imdbId to directly download a title.
@adoxa adoxa mentioned this issue Sep 12, 2022
Merged
Huevos pushed a commit that referenced this issue Sep 12, 2022
@adoxa @Huevos
[imdb] Big update
72a47cc 
Replace the regex searches with JSON data that's included in the page,
including the translations provided by IMDb.  The storyline & tagline
are downloaded separately.

Use requests for downloads (resolves #528); update the dependents.

Press MEDIA to download and display a bigger poster; press TEXT to
display a synopsis (if available; this may require a skin change to add
"VKeyIcon").

Save is always available (parameter still exists, but is ignored), using
"/home/root/logs/imdb" if no path is specified.  Use "-TITLEID" instead
of ".imdbquery2".  HTML will save the poster; text will be similar to
how it's displayed; text with poster will use the big poster if it's
been downloaded, otherwise the full-size poster will be retrieved.

quoteEventName stopped using the safe list, remove it.

Add new parameter imdbId to directly download a title.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[imdb] Big update adoxa/enigma2-plugins
1 participant
@jbleyel