Skip to content

Commit

Permalink
fixes DecisionTreeRegressor bug with sklearn 0.24
Browse files Browse the repository at this point in the history
  • Loading branch information
oegedijk committed Dec 23, 2020
1 parent 21354f0 commit 2533b1d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 6 additions & 0 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@


## Dashboard:
- add reloader=None, debug=None, host=None options
- add waitress to run options
- add SimpleClassifierDashboard
- add SimpleRegressionDashboard
Expand All @@ -62,6 +63,10 @@
## Hub:
- automatic reloads with watchdog
- add dashboard specific logins
- add reloader=None, debug=None, host=None options
- add Flask-Login support
- add explainerhub CLI
- add user management

### Components
- autodetect when uuid name get rendered and issue warning
Expand Down Expand Up @@ -91,6 +96,7 @@
- Add this method? : https://arxiv.org/abs/2006.04750?

## Tests:
- add tests for InterpretML EBM (shap 0.37)
- write tests for ExplainerHub
- test model_output='probability' and 'raw' or 'logodds' seperately
- write tests for explainer_methods
Expand Down
3 changes: 2 additions & 1 deletion explainerdashboard/explainer_plots.py
Original file line number Diff line number Diff line change
Expand Up @@ -2131,7 +2131,8 @@ def plotly_rf_trees(model, observation, y=None, highlight_tree=None,
f"{highlight_tree} is out of range (0, {len(model.estimators_)})"
colors[highlight_tree] = 'red'

if model.estimators_[0].classes_[0] is not None: #if classifier
if (hasattr(model.estimators_[0], "classes_")
and model.estimators_[0].classes_[0] is not None): #if classifier
preds_df = (
pd.DataFrame({
'model' : range(len(model.estimators_)),
Expand Down

0 comments on commit 2533b1d

Please sign in to comment.