Skip to content

Commit

Permalink
fixes dbc.RadioButton bug (#214)
Browse files Browse the repository at this point in the history
* update assets (copy of bootstrap resources)

* migration to bootstrap 5

* fixup explainer hub nav

* upstream fix of #201

* fixup dbc.Card argument

* adds contributing.md

* updates dbc.RadioButton to use value parameter

With dbc-v1 the parameter changed from checked to value.

* suppresses fitted without feature names warnings

* supresses dash_auth dash v1 imports warnings

(temporary fix until dash_auth gets fixed and made compatible with
dash v2)

* filter warnings missing feature names all models

* smaller and better aligned dbc.Select

Co-authored-by: Achim Gädke <achim@montoux.com>
Co-authored-by: Oege Dijk <oege.dijk@fourkind.com>
  • Loading branch information
3 people committed May 6, 2022
1 parent ac40a6f commit b90d4ff
Show file tree
Hide file tree
Showing 16 changed files with 489 additions and 11,030 deletions.
46 changes: 46 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# Contributing

## Runnning tests offline

When submitting a PR github can run the full testsuite using github actions. For running the tests offline you
need to make sure you have installed all the required offline testing requirements:

### virtual environment

First create a new virtual environment:

`$ python -m venv venv`
`$ source venv/bin/activate`

### install dependencies and CLI tools

First make sure you have the latest version of pip itself:
`$ python -m pip install -U pip setuptools wheel`

Then install the whole package including dependencies:
`$ pip install -e .`

(this also install the CLI tools in the path)

### install testing dependencies

There are additional libraries such as selenium, xgboost, catboost, lightgbm etc needed for testing:

`$ pip install -r requirements_testing.txt`

(lightgbm may give some headaches when installing with pip, so can also `brew install lightgbm` instead)

### install chromedriver for integration tests

For the integration tests we use Selenium which launches a headless version of google chrome to launch a dashboard
in the browser and then checks that there are no error messages. In order to run these tests you need to download
a chromedriver that is compatible with your current installation of chrome at https://chromedriver.chromium.org/

You then unzip it and copy it to `$ cp chromedriver /usr/local/bin/chromedriver`
and on OSX allow it to be run with `$ xattr -d com.apple.quarantine /usr/local/bin/chromedriver`.

### running the tests

The tests should now run in the base directory with

`$ pytest .`

0 comments on commit b90d4ff

Please sign in to comment.