-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure of the demandlib #1
Comments
Today me and @uvchik talked about the contents and aim of the demandlib. Our suggestion to keep it as lean as possible and to have only the profile functionality (bdew, industry) for electricity and heat included. A library like this we would like to keep as a part of oemof We think the best way achieving this is to write a library from scratch again including all necessary existing contents to get rid of the not at all lean structure of the current demandlib (and maybe rename it to profilelib). All other development on demand topics should be done in project repositories only. If it then turns out that there are reasons of making some of these a part of the demandlib/profilelib we can discuss this at a given time. What do you think? |
I had similar thoughts about rewriting it from scratch while discussion the industrial load profile integration... |
Started with the heat profiles. I think the structure of the electrical profiles will be more simple because less parameters are needed. Maybe a dictionary as input and a DataFrame as output:
Just an idea. Who will transfer the electrical profiles? |
As far as I know this is exactly the data structure we have used before, see: Do you mean this? |
I'm going to do this next week. |
Done. Could anyone test it and tell me if I missed something? |
Here are my ideas:
@caro-rli The latest commits realised all my ideas from above. If you do not like them, revert them (or ask me to revert them because my commits are not as clean as they should be). Is it possible to get profiles for periods of 2 hours, 30 minutes, 15 minutes? I did not test it but I think this would be a nice feature. |
With the heat example I get an error
I've got numpy 1.11.0 |
I like them except for number 4 as I don't understand. I think additionally we should have examples for the various options of the industrial profiles. I have made a suggestion in the power example file. |
I'm still not convinced if this is necessary since we wanted to leave out all own calculations. |
Okay, removed this option. Now the only output of the electricity profiles are 15-minute values. The output of the industrial profile depends on the passed datetime index.
|
Thanks for the implementation work. I had short look on it -- looks good! Maybe there will be some future feature additions by the open_ego team, but this can't be said for sure right now. We think of
In addition, whats about the demand profiles of the HTW guys? Would this be interesting for this lib? |
I do not know these profiles but I would appreciate every kind of contribution.
Feel free 😄 |
I know these profiles and I'm currently using them. I could add them, but we should:
|
@caro-rli : Would you ask them? Then you could open an new issue/PR. |
Ok
Is working now with pandas 0.18 |
If it works we can close this issue. @caro-rli I moved the idea of the HTW profiles to issue #7 . |
You wanted to answer the following questions:
The text was updated successfully, but these errors were encountered: