Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Remove obsolete modules #39

Merged
merged 22 commits into from May 25, 2020
Merged

Remove obsolete modules #39

merged 22 commits into from May 25, 2020

Conversation

uvchik
Copy link
Member

@uvchik uvchik commented May 22, 2020

  • I remove the obsolete and unsed modules
  • fixed some tests
  • moved the content of __initi__.py to connect.py

@uvchik uvchik requested review from gnn and henhuy May 22, 2020 08:19
@uvchik uvchik self-assigned this May 22, 2020
@uvchik
Copy link
Member Author

uvchik commented May 22, 2020

@henhuy The doctests of the results module fail. I disabled them to get a working start point but you should enable and fix them.

@uvchik uvchik mentioned this pull request May 25, 2020
@henhuy henhuy mentioned this pull request May 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #39 into dev will increase coverage by 46.59%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             dev      #39       +/-   ##
==========================================
+ Coverage   7.95%   54.54%   +46.59%     
==========================================
  Files          8        6        -2     
  Lines        415      264      -151     
  Branches      52       31       -21     
==========================================
+ Hits          33      144      +111     
+ Misses       381      118      -263     
- Partials       1        2        +1     
Impacted Files Coverage Δ
src/oemof/db/results.py 0.00% <0.00%> (ø)
src/oemof/db/connect.py 35.71% <35.71%> (ø)
src/oemof/db/__init__.py 100.00% <100.00%> (+64.28%) ⬆️
src/oemof/db/config.py 92.59% <100.00%> (+67.59%) ⬆️
tests/config_tests.py 100.00% <100.00%> (ø)
tests/import_tests.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d4fb4...9366754. Read the comment docs.

@uvchik
Copy link
Member Author

uvchik commented May 25, 2020

I do not like the structure of config.py but nevertheless, I added some tests. If we find some time we should revise this module....

@uvchik uvchik merged commit 8e96802 into dev May 25, 2020
@uvchik uvchik deleted the remove-obsolete-modules branch May 25, 2020 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants