Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework generic starting value generator and convergence checks #297

Open
fwitte opened this issue Dec 21, 2021 · 0 comments
Open

Rework generic starting value generator and convergence checks #297

fwitte opened this issue Dec 21, 2021 · 0 comments

Comments

@fwitte
Copy link
Member

fwitte commented Dec 21, 2021

Currently, generating the starting values mostly works with water due to the way the project grew. However, they should depend on the functionality of the component as well as the fluid (maybe even the label?), i.e.

  • compressor: inlet and outlet state both gaseous
  • turbine: inlet and outlet state both gaseous
  • pump: inlet and outlet state both liquid
  • condenser:
    • inlet state hot side: saturated gas
    • outlet state hot side: saturated liquid
    • inlet/outlet state cold side: both liquid or gaseous
  • desuperheater:
    • inlet state hot side: gaseous
    • outlet state hot side: saturated gas
    • other side: both liquid or gaseous
  • heat exchanger: ???
  • solar collector and parabolic trough: liquid at inlet and outlet
  • ... to complete this list...

Similar checks can be carried out for the convergence_check functions of these components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant