Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module titling problems #174

Closed
2 tasks
kathi-fletcher opened this issue Mar 14, 2014 · 1 comment · Fixed by oerpub/bookish#31
Closed
2 tasks

Fix module titling problems #174

kathi-fletcher opened this issue Mar 14, 2014 · 1 comment · Fixed by oerpub/bookish#31

Comments

@kathi-fletcher
Copy link
Member

In testing various fixes that Izak made, I realized that the metadata titling is not working right at all and I am a little worried that one of the things I merged might be at fault.

  • If I create a new module, the title doesn't show up at all in the module.
  • If I open an old module, the title in the nav is there, but in the module the title is "untitled".

We have this situation where the module metadata is now in the module and needs to be synchronized with the nav file. Since the nav file and the module both have a copy of the title part of the metadata, those have to be synchronized. Tom had this working at one point, but it has gotten wonked. Note that changes to the metadata in the -nav get saved automatically, and changes to the metadata in the module must be hand saved. The "Save all" button must light up when the title is changed using "rename" in the nav, or using the metadata diagog in the module.

@izak
Copy link

izak commented Mar 24, 2014

Ok, I think I found at least one issue. oerpub/bookish@0bc6531 hooked up an event handler to a title change, and before I fixed the problem where attributes were being set inside OpfFile::parse this would have fired, but it will no longer work. So this is the first problem.

I suspect the same issue with oerpub/bookish@9f69f22.

So this was indeed "broken" by ce6d259.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants