Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI test matrix #348

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

wynksaiddestroy
Copy link
Contributor

@wynksaiddestroy wynksaiddestroy commented Jul 4, 2024

As #342 seems to got stuck. Here's a new attempt:

  • remove unsupported Ruby Versions (2.7 and 3.0)
  • add Ruby head
  • use latest checkout action version

@ronwsmith
Copy link
Collaborator

Thanks for the contribution! I don't think the failures are related but can you take a look and see if you can resolve them?

@wynksaiddestroy
Copy link
Contributor Author

wynksaiddestroy commented Jul 5, 2024

Thanks for the contribution! I don't think the failures are related but can you take a look and see if you can resolve them?

I'm not quite sure how to address this issue properly. It seems that calling

will somehow cause the browser to actually visit https://example.com(:443). Thus trying to find the stub will fail. See d831973 for a provisional fix.

@ronwsmith
Copy link
Collaborator

@wynksaiddestroy I'm good with that fix, thanks! Looks like there are problems running on Ruby head though now.

Can you take a look (or remove head)?

@wynksaiddestroy
Copy link
Contributor Author

@wynksaiddestroy I'm good with that fix, thanks! Looks like there are problems running on Ruby head though now.

Can you take a look (or remove head)?

It's because em-socksify doesn't have base64 as an (explicit) dependency yet. I already created a PR. See igrigorik/em-socksify#25
I propose we'll wait a few days an see whether the PR gets merged soon.

@ronwsmith
Copy link
Collaborator

Looks like the other PR was merged but CI here is still failing. Please let me know when I should try again.

@wynksaiddestroy
Copy link
Contributor Author

Looks like the other PR was merged but CI here is still failing. Please let me know when I should try again.

There's no new version released yet. I just asked the author, if he plans to do it.

@wynksaiddestroy
Copy link
Contributor Author

@ronwsmith A new version of em-socksify just got released. Could you please try again?

@ronwsmith
Copy link
Collaborator

Huzzah, thanks for the contribution!

@ronwsmith ronwsmith merged commit 89e7ed3 into oesmith:master Jul 18, 2024
4 checks passed
@ronwsmith ronwsmith mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants