-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workarounds for minted bugs #91
Conversation
f4b739e
to
479e24c
Compare
Thanks for your work for fixing the build issue. May I greedily ask one more question for myself? For me I find it harder to read serif fonts on PC monitors, and I wish to follow this book's content with sans-serif font. I've read that I can use |
I'm trying out your patch but still got this error:
|
Check LaTeX is failing |
I can't reproduce it. Could you try removing
The main font of the document is declared here: Lines 35 to 39 in 7ccacc2
If you replace these lines with \setmainfont{Latin Modern Sans} (or use other font of your liking) then most of the document will be written in sans serif. Keep in mind that some examples will still produce serif output and that there may be some issues with layout.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go
Since version 2.7
minted
is using new input processing macros which are not entirely backwards compatible. This breaks our CI since we were relying on some old behaviors. This PR adds workarounds for two bugs that prevented the book from building with the newestminted
.Fixes #90