Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or update generated files in repository #1163

Closed
ryandesign opened this issue Mar 20, 2022 · 1 comment · Fixed by #1170
Closed

Remove or update generated files in repository #1163

ryandesign opened this issue Mar 20, 2022 · 1 comment · Fixed by #1170

Comments

@ryandesign
Copy link
Contributor

Describe the bug
The repository contains generated autotools files—configure, several Makefile.in, the conftools directory, etc.—but they were not updated for the recent 1.8.0 release. If a user clones the repository or downloads an automatically generated tarball of 1.8.0 and configures and builds, the program will misidentify itself as version 1.7.2.

The files in the release tarball were updated properly, so users downloading the release tarball will not have this problem.

I suggest either removing the generated files from the repository (most projects do this) or updating them to the ones that are in the release tarball.

To Reproduce
Steps to reproduce the behavior:

  1. Download https://github.com/oetiker/rrdtool-1.x/archive/refs/tags/v1.8.0.tar.gz
  2. configure, make, sudo make install as usual
  3. Run rrdtool --version

Expected behavior

$ rrdtool --version
RRDtool 1.8.0  Copyright by Tobias Oetiker <tobi@oetiker.ch>
               Compiled Mar 20 2022 16:37:57

Usage: rrdtool [options] command command_options
Valid commands: create, update, updatev, graph, graphv,  dump, restore,
		last, lastupdate, first, info, list, fetch, tune,
		resize, xport, flushcached

RRDtool is distributed under the Terms of the GNU General
Public License Version 2. (www.gnu.org/copyleft/gpl.html)

For more information read the RRD manpages

Actual behavior

$ rrdtool --version
RRDtool 1.7.2  Copyright by Tobias Oetiker <tobi@oetiker.ch>
               Compiled Mar 20 2022 11:05:37

Usage: rrdtool [options] command command_options
Valid commands: create, update, updatev, graph, graphv,  dump, restore,
		last, lastupdate, first, info, list, fetch, tune,
		resize, xport, flushcached

RRDtool is distributed under the Terms of the GNU General
Public License Version 2. (www.gnu.org/copyleft/gpl.html)

For more information read the RRD manpages

Desktop (please complete the following information):

  • OS: macOS 10.15.7
ryandesign added a commit to macports/macports-ports that referenced this issue Mar 20, 2022
@ryandesign
rrdtool: Use release tarball; fixes version number
75d7770 
The previous 1.8.0 version of this port used an automatically generated
tarball. The git repository contains an outdated configure script and
associated files that were not updated for the 1.8.0 release so the
program misidentified itself as 1.7.2, among who knows how many other
unintended differences. By switching to the release tarball we pick up
the version number change and any other bugfixes or changes that the
developers made in configure.ac, m4 files, and Makefile.in files.

oetiker/rrdtool-1.x#1163

Also fix implicit declaration of functions in configure script.

oetiker/rrdtool-1.x#1162
c72578 added a commit to c72578/rrdtool-1.x that referenced this issue Mar 22, 2022
@c72578
Update Version and Copyright year in git files
7e9b4b8 
This commit is based on running the first part of the rrdtool-release
script (before bootstrap).

- Resolves Version part of oetiker#1163
@c72578 c72578 mentioned this issue Mar 22, 2022
Merged
c72578 added a commit to c72578/rrdtool-1.x that referenced this issue Mar 22, 2022
@c72578
Update Version and Copyright year in git files
e839e17 
This commit is based on running the first part of the rrdtool-release
script (before ./bootstrap).

- Part of oetiker#1163
c72578 added a commit to c72578/rrdtool-1.x that referenced this issue Apr 5, 2022
@c72578
Remove autogenerated files
ff6d3a8 
The removed files are generated using bootstrap
(libtoolize, autoreconf) and they are available in release tarballs.

- Avoids outdated configure file in git
- Resolves oetiker#1163
- The following commands have been used for removal:
  git rm configure
  git rm Makefile.in
  git rm *Makefile.in
  git rm src/rrd_config.h.in
@c72578 c72578 mentioned this issue Apr 5, 2022
Merged
c72578 added a commit to c72578/rrdtool-1.x that referenced this issue Apr 5, 2022
@c72578
Remove autogenerated files
99275bf 
The removed files are generated using bootstrap
(libtoolize, autoreconf) and they are available in release tarballs.

- Avoids outdated configure file in git
- Resolves oetiker#1163
- The following commands have been used for removal:
  git rm configure
  git rm -r conftools/
  git rm Makefile.in
  git rm *Makefile.in
  git rm src/rrd_config.h.in
@rodry285
Copy link

rodry285 commented May 7, 2024

Describa el error. El repositorio contiene archivos de autotools generados (configure, varios Makefile.in, el directorio conftools, etc.), pero no se actualizaron para la reciente versión 1.8.0. Si un usuario clona el repositorio o descarga un tarball generado automáticamente de 1.8.0 y lo configura y compila, el programa se identificará erróneamente como la versión 1.7.2.

Los archivos en el archivo tar de la versión se actualizaron correctamente, por lo que los usuarios que descarguen el archivo tar de la versión no tendrán este problema.

Sugiero eliminar los archivos generados del repositorio (la mayoría de los proyectos hacen esto) o actualizarlos a los que están en el tarball de lanzamiento.

Para reproducir Pasos para reproducir el comportamiento:

  1. Descargar https://github.com/oetiker/rrdtool-1.x/archive/refs/tags/v1.8.0.tar.gz
  2. configure, make, sudo make installcomo siempre
  3. Correrrrdtool --version

Comportamiento esperado

$ rrdtool --version
RRDtool 1.8.0  Copyright by Tobias Oetiker <tobi@oetiker.ch>
               Compiled Mar 20 2022 16:37:57

Usage: rrdtool [options] command command_options
Valid commands: create, update, updatev, graph, graphv,  dump, restore,
		last, lastupdate, first, info, list, fetch, tune,
		resize, xport, flushcached

RRDtool is distributed under the Terms of the GNU General
Public License Version 2. (www.gnu.org/copyleft/gpl.html)

For more information read the RRD manpages

Comportamiento real

$ rrdtool --version
RRDtool 1.7.2  Copyright by Tobias Oetiker <tobi@oetiker.ch>
               Compiled Mar 20 2022 11:05:37

Usage: rrdtool [options] command command_options
Valid commands: create, update, updatev, graph, graphv,  dump, restore,
		last, lastupdate, first, info, list, fetch, tune,
		resize, xport, flushcached

RRDtool is distributed under the Terms of the GNU General
Public License Version 2. (www.gnu.org/copyleft/gpl.html)

For more information read the google mail pages

Dispositivo movil (por favor complete la siguiente información):

  • SO: android 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove autogenerated files c72578/rrdtool-1.x
2 participants
@ryandesign @rodry285