rrdcached dump support #1235
rrdcached dump support #1235
Conversation
Help strings for TUNE command were lacking the trailing newline character. This causes the FLUSH syntax printed in the same line as TUNE's.
The `sendall` func is implemented as a loop over multiple send() calls until all bytes are sent. Previously on subsequent calls the incorrect buffer was used for sending. This change also forbids `allow_retry` when at least one byte was successfully sent already. This would otherwise mess up the protocol, when retrying from the start.
Previously, tests replaced the daemon-based dump use with a local use. This is changed in this commit as dump is now supported via daemon.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
==========================================
+ Coverage 50.96% 50.97% +0.01%
==========================================
Files 45 45
Lines 18093 18214 +121
==========================================
+ Hits 9221 9285 +64
- Misses 8872 8929 +57
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The grep 404 was recently "recently" fixed upstream: microsoft/vcpkg#29067 Would this need a bump of the |
@thz please try :) |
I just tested a manual vcpkg run from github.com/microsoft/vcpkg HEAD and it succeeded building the deps (including a slightly newer grep version). So I committed the SHA1 of the last tag as |
|
Here is some background info concerning the updated vcpkg, which is part of this PR:
|
|
Oh nice. Ready for merge then. |
|
thank you! |
vcpkg has been updated to 2023.10.19 Release, commit 8eb5735 in oetiker#1235. The name of libffi.dll has changed to ffi-8.dll. - Update `collect_rrdtool_vcpkg_files.bat`, which is used by the `release-windows.yml` GitHub Action: libffi.dll -> ffi-8.dll
vcpkg has been updated to 2023.10.19 Release, commit 8eb5735 in #1235. The name of libffi.dll has changed to ffi-8.dll. - Update `collect_rrdtool_vcpkg_files.bat`, which is used by the `release-windows.yml` GitHub Action: libffi.dll -> ffi-8.dll
fixes #1141