Fix failing test pdp-calc1 #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of decimal places or the format can be different in the output depending on the platform. - The failing test has appeared under msys2 (MINGW32 and MINGW64), where the exponential notation has changed: E.g. e+000 instead of e+00 - Use DIFF9 also in test pdp-calc1, which reduces the number of decimal places to 7 using "%0.7e". See DIFF9 in tests/functions. - Update the pdp-calc1 output files accordingly - Fixes failing test pdp-calc1 under msys2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1245 +/- ##
=======================================
Coverage 51.02% 51.02%
=======================================
Files 45 45
Lines 18214 18214
=======================================
Hits 9294 9294
Misses 8920 8920 ☔ View full report in Codecov by Sentry. |
|
From current Windows CI / msys2 (windows-2022, x86_64) log file: |
oetiker
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of decimal places or the format can be different in the
output depending on the platform.
where the exponential notation has changed:
E.g.
e+000instead ofe+00DIFF9also in testpdp-calc1, which reduces the number ofdecimal places to 7 using
"%0.7e". SeeDIFF9intests/functions.pdp-calc1output files accordinglypdp-calc1under msys2