New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mojo::IOLoop::ForkCall deprecated, use Mojo::IOLoop::Subprocess instead #494
Comments
I'm the maintainer of the module in question: (a) yes usually changing the module name is that easy, there are some slight differences especially if you are using the events it emits, but for simple usage it is an easy port and (b) I'm not going to delete it from CPAN any time in the near future. Worst case is it gets less maintenance than I'd normally do. Certainly you should port it so that you get better support from Mojo core but don't fear that I'm going to intentionally cause outages. |
@ahesford will certainly be updating to the new subprocess approach ... but for now, you can just continue using it as is. |
Thank you both for your responses. I am not currently using |
Just in case, is this new method introduced recently? A bit back I did have to amend the configure script (and requirements file) to require an older Mojolicious version if running with perl-5.10 for example. Being quite cross-platform, including Solaris 10 systems still running, |
subprocess has been around for quite some time ... |
FYI, this has broken the spike repo znapzend RPM on Fedora 33, as there is no longer a perl-Mojo-IOLoop-ForkCall RPM available :-( |
Unfortunately system packagers rarely if ever communicate with upstream library authors. I was neither aware that there had been an rpm for it nor that it no longer had one. Personally I always recommend getting your CPAN dependencies from CPAN. Distro packagers do a service, but not one that we CPAN authors can control or even see. |
Sorry about that, it should be fixed now. |
Closing because I'm not really thinking about this anymore. |
Replace ForkCall with Subprocess, fix #494
I'm looking to package
znapzend
for Void Linux, but found that Mojo::IOLoop::ForkCall is marked deprecated by the maintainer. The preferred replacement is Mojo::IOLoop::Subprocess, built right into Mojolicious.A quick review of
znapzend
and theMojo::IOLoop::Subprocess
documentation leads me to believe that moving to the preferred replacment is as simple ass/ForkCall/Subprocess/
inlib/ZnapZend.pm
andlib/ZnapZend/ZFS.pm
, but I am neither a very sophisticated Perl hacker nor terribly familiar withznapzend
.The text was updated successfully, but these errors were encountered: