First steps to drop unsupported MW and PHP #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah. I delved into my hook registry, trying to fix the mentioned issue. It will take a little bit more than simply exchaning a function call. To be sure: Unsupported means everything before 1.35? |
Yes. < MW 1.35 and < PHP 7.4, since both of those are EOL upstream. This is the same we did for Chameleon. |
|
Not specificly "in public". I have some constraints on premise, but no need to postpone b/c of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't look at any test or code issues yet, but with issues like #31 coming up we need to start dropping unsupported versions.