Make it work #39
Open
Make it work #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ability (on render side) to bind js calls in OF
- On Windows use our `ofxCEFClientApp` class as render process - Make `updateCEF` a global function like `initofxCEF` because it only has to run once (not per instance) - Make 'setup` a bit smarter with url and size arguments - Resize events can be separately dis- and enabled - Add a `reload` method - Add logic for creating JS function bindings - Implemented OF mouseScrolled method - Add some `OVERRIDE` to overridden methods - Tell the browser when V8 context is created and released
- Correct use of `width_` and `height_` members
…g with a different width or height
- Add 'CefLifeSpanHandler' to 'ofxCEFBrowserClient' - Check for NULL pointer - Use a more general method 'isReady()' instead of 'isRendererInitialized()' - Update examples to reflect the changes
|
Wow, nice. I'm definitely going to give this a try. |
…positive value - When a cef subprocess exits for some reason before the app is closed it'll open another instance of the oF app - With newer cef versions a 'gpu-process' is created after a few seconds which needs to exit correctly
|
Hi Michael, any ideas? BTW, I wanted to raise this as an issue on your fork, but you don't have issues enabled, so I hope its OK to raise it here. |
|
@rjx-ray I've enabled issues on my fork now. Just to be sure, did you switch to to the |
|
Thanks for the quick response Michael, I’ll double check.
BTW do you have any idea about #40
- Richard
*From:* Michael Baisch <notifications@github.com>
*Sent:* 24 July 2018 10:10
*To:* ofZach/ofxCef <ofxCef@noreply.github.com>
*Cc:* Richard Jackson <richard@igloovision.com>; Mention <
mention@noreply.github.com>
*Subject:* Re: [ofZach/ofxCef] Make it work (#39)
@rjx-ray <https://github.com/rjx-ray> I've enabled issues on my fork now.
Just to be sure, did you switch to to the make_it_work branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AXvRt-0xgYLg_oDzEvBT7NBk1fpiMU73ks5uJuRQgaJpZM4Reoq0>
.
…--
Subscribe to the Igloo newsletter
<http://igloovision.us6.list-manage.com/subscribe?u=f76bf4dd96af03cb03898feda&id=1a3cbff1b0>.
This e-mail including any attachments is confidential and may be legally
privileged. If you have received it in error please advise the sender
immediately by return email and then delete it from your system. The
unauthorized use, distribution, copying or alteration of this email is
strictly forbidden. Email communications cannot be guaranteed to be secure
or error free, therefore, Igloo Vision Ltd does not accept liability for
any errors, omissions or viruses. Any opinions contained in this message
are those of the author and are not given or endorsed by Igloo Vision Ltd
unless the context so requires that to be the case.
*Igloo Vision Ltd *
Registered Address: Unit 2, Craven Court, Stokewood Rd, Craven Arms,
Shropshire, SY7 8PF, UK Company Number: 06628206 *Igloo Vision USA, Co.
*Registered address: c/o Dyke Yaxley LLC, 3700 Park East Drive, Suite 250,
Cleveland,
<https://maps.google.com/?q=3700+Park+East+Drive,+Suite+250,+Cleveland,+OH+44122,+USA&entry=gmail&source=g>OH
44122, USA Corporation Number: 6035749 *Igloo Vision Canada Inc* Registered
address: 375 Water St, Suite 680, Vancouver BC V6B5C6, Canada Company
Number: BC1135255 Ontario Company Number: 1983760 *Igloo Vision PTY Ltd*
Registered Address: Woodstock, 2761 Nangus Road, Nangus, NSW, 2722,
Australia Company Number: 624824746
Please consider the
environment before printing this email.
|
|
That was the problem, I hadn't switched to the right branch, thanks |
… as required by the macOS sandbox implementation. https://bitbucket.org/chromiumembedded/cef/commits/fcad76b405b84f23175c039ae9ca901502232053
…mmunication with helper process might not be working.
- SendProcessMessage was moved from CefBrowser to CefFrame - OnBrowserCreated added param - GetViewRect method changed return-type from bool to void - Using multiple helper app bundles (GPU, Plugin, Renderer) see: https://bitbucket.org/chromiumembedded/cef/commits/e067612e55e371642188c7faf6b629df90a3b34e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to bring the setup steps down to a minimum and makes the entry barrier as small as possible. While making it work on macOS and Windows in a reproducible way. This might be the new common ground to further improve ofxCef and discuss detail problems instead of using energy on "how to compile"-problems.
apothecaryto automatically build the CEF libsimple,communication, andmultiofBaseDrawsto have nice drawing methodsCloses #38 #36 #34 #32 #31 #29 #28 #27 #23