Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross compiling fails with 1.16.1 #72

Closed
heitbaum opened this issue May 3, 2022 · 6 comments · Fixed by #79
Closed

Cross compiling fails with 1.16.1 #72

heitbaum opened this issue May 3, 2022 · 6 comments · Fixed by #79
Assignees

Comments

@heitbaum
Copy link

heitbaum commented May 3, 2022

With the addition of libcheck and the logic in the configure script.

  • Configure finds the include check.h in /user/include (not the sysroot). Using —with-check to the cross compile sysroot/usr allows the build to complete.

it would be nice to be able to disable libcheck during build too.

@ofalk
Copy link
Owner

ofalk commented May 3, 2022

Thanks for reporting this issue.
I agree, check could be optional, as it's only used for the test suite. So basically, if check is available we could build the tests, else don't. Let me think about this.

@ofalk
Copy link
Owner

ofalk commented May 3, 2022

ok. Back to this. If you'd be willing to support me with a MR/patch, that would be highly appreciated. I'm happy to review it, but I'm currently stressed a bit...

@heitbaum
Copy link
Author

heitbaum commented May 3, 2022

No problems. Let me take a look.

@ofalk
Copy link
Owner

ofalk commented Jan 11, 2023

Any update on this?

@chenrui333
Copy link
Contributor

@ofalk and @heitbaum 👋 I have introduced a --enable-check flag to help me out with the build issue on the homebrew side, let me know if that works for both of you. Thanks!

@ofalk ofalk closed this as completed in #79 Jan 23, 2023
@ofalk
Copy link
Owner

ofalk commented Jan 23, 2023

Again, thanks a lot @chenrui333 !

@ofalk ofalk self-assigned this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants